-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PySide6 Support (squash) #394
Changes from 3 commits
80dc006
822cac0
a25cc94
55889ed
47ac768
f993695
5209c24
39c28dd
c0d64e0
d855ccf
e23780c
f9b4ca1
6d6f955
158651d
392f0cd
4e1fd21
606010c
5083eb9
a31ea4a
da81b09
3105351
a3dffae
f8e4124
55a9c7b
0cea915
7ca0224
af8af75
73a6ba4
42395b6
5493aa0
93ab974
7351971
d65eaf9
fed4836
c4b202d
e6edaa8
3967fe4
66e379b
25e117d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: Run PySide6 Tests | ||
|
||
on: | ||
push: | ||
branches: | ||
- "*" | ||
pull_request: | ||
branches: | ||
- "*" | ||
|
||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
include: | ||
- os: ubuntu-latest | ||
VFXPLATFORM: "2018" | ||
PYTHON: "3.6" | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: pip install PySide6 | ||
run: | | ||
pip install PySide6 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose
|
||
|
||
- name: Run tests in Docker container | ||
run: | | ||
docker run --rm \ | ||
-v $(pwd):/Qt.py \ | ||
-e PYTHON=${{ matrix.PYTHON }} \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line runs a Docker container, which we would no longer need in this case. Instead, call the run: PYTHON=3.11 ./entrypoint.sh Set PYTHON=3.10 or 3.11, depending on which version of Python There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From here, it looks like Ubuntu 22. It would be safe to set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, I just had a look: Ubuntu 22 seems to ship with Python 3.10. |
||
fredrikaverpil/qt.py:${{ matrix.VFXPLATFORM }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, the
strategy:
block can go away.A
strategy: matrix:
block is used to execute tests within the Docker container multiples times in a row inrun-tests.yml
, using different parameters.→ I think this does not have any use in here, and can be removed.