Fix #137 #138
Merged
Fix #137 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um. I'm not clear on when this issue is triggered. From your example, PySide.QtWidgets must've been created by the user somehow if Qt.py cannot map to it? |
|
Since I've never seen this issue I was just curious about when you hit it. |
You and me both. I never expected to experience it, but it happened and when it did I had no clue about how to find the cause. That feeling is what compelled me to disable it at run-time. Overall it should be harmless. If anything is overwritten in a vanilla session, it would still be caught by our tests. |
|
Ok, then this looks good to me. :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable run-time testing of attribute overrides.
See original issue #137.