Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace requestAnimationFrame timestamp with performance.now() #2281

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Replace requestAnimationFrame timestamp with performance.now() #2281

merged 1 commit into from
Aug 7, 2023

Conversation

mattgperry
Copy link
Collaborator

In Chrome, the timestamp provided to requestAnimationFrame callbacks is erroneously the time of rAF invocation, not the time of the callback's invocation. Instead, we use performance.now() to get the actual time.

Avoids https://bugs.chromium.org/p/chromium/issues/detail?id=1470675#makechanges

@mattgperry mattgperry requested a review from nvh August 7, 2023 11:33
@mergetron mergetron bot merged commit f6123e5 into main Aug 7, 2023
@mergetron mergetron bot deleted the fix/handoff-2 branch August 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvh nvh nvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattgperry @nvh