Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable.Set Should Invalidated the Cached Value #73

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

antJack
Copy link
Contributor

@antJack antJack commented Dec 20, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 49.54% // Head: 49.56% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (39f3d97) compared to base (80d7c72).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   49.54%   49.56%   +0.01%     
==========================================
  Files          56       56              
  Lines        2985     2986       +1     
==========================================
+ Hits         1479     1480       +1     
  Misses       1407     1407              
  Partials       99       99              
Impacted Files Coverage Δ
variable/api.go 70.11% <100.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nejisama
Copy link
Collaborator

之前的改动中,简化了缓存flag的设置
4d6d910
导致存在这个问题

@nejisama
Copy link
Collaborator

see #75

Copy link
Contributor

@taoyuanyuan taoyuanyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nejisama
Copy link
Collaborator

see #75

this one is better

@nejisama nejisama merged commit 9f61ba1 into mosn:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants