Also persist QoS 0 subscriptions when clean flag false #694
Conversation
|
@mcollina Please check what is going on with the Travis Build and it fails.. .Locally with Node v8.7.0 everything succeeds.. Thanks |
|
@mcollina Sorry to insist on the issue, but because we are using Mosca in a production environment, and this bug affects us, I would prefer to use the corrected version instead of monkey patching the module code after running, could you please check if anything else is needed for the Travis Build to work? Because I think the errors are irrelevant, since in my local environment all tests succeed. |
lib/persistence/levelup.js
Outdated
| //if (client.subscriptions[key].qos > 0) { // Issue #693 | ||
| subscriptions[key] = client.subscriptions[key]; | ||
| subscriptions[key].ttl = that.options.ttl.subscriptions + now; | ||
| //} // Issue #693 |
There was a problem hiding this comment.
can you remove these comments?
lib/persistence/redis.js
Outdated
| } | ||
| // if (client.subscriptions[key].qos > 0) { // Issue #693 | ||
| subscriptions[key] = client.subscriptions[key]; | ||
| //} // Issue #693 |
There was a problem hiding this comment.
can you remove these comments?
| @@ -558,7 +558,7 @@ module.exports = function(create, buildOpts) { | |||
| }); | |||
| }); | |||
|
|
|||
| it("should not store a QoS 0 subscription", function(done) { | |||
| it("should store a QoS 0 subscription", function(done) { | |||
There was a problem hiding this comment.
can you please check/add a test that we are not enqueuing QoS 0 packets?
There was a problem hiding this comment.
Can you tell me what you mean? You already have test for QoS 0 packages
There was a problem hiding this comment.
Eeeee... what comment???? ;)
|
Ok just removed the comments! Thanks! |
|
Thanks! Releasing asap. |
No description provided.