This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
remove moment #631
Closed
remove moment #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing :/. |
|
@eljefedelrodeodeljefe ping! |
jyotman
reviewed
May 5, 2017
| @@ -179,7 +176,7 @@ Stats.prototype.wire = function wire(server) { | |||
|
|
|||
| doPublish("version", version); | |||
| doPublish("started_at", server.stats.started.toISOString()); | |||
| doPublish("uptime", mom.from(Date.now(), true)); | |||
| doPublish("uptime", Math.ceil((Date.now() - this.started) / 1000) + ' seconds'); | |||
There was a problem hiding this comment.
@mcollina I think we just need to replace this with server.stats to pass the failing test.
|
@jyotman would you like to send an updated PR, and take over from @eljefedelrodeodeljefe ? |
|
@mcollina sure! Will submit a PR soon 👍 |
|
Sorry for inactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very tiny nit: I came by this line and thought it might be a little overkill. Removing moment from this one single line has a 2mb node_moulues decrease when installed without production flag.