mqtt over websocket on different path

[namgk]

Fixes this #605

[mcollina]

Can you add a unit test for this?

[namgk]

I don't see we have any test for attachHttpServer yet, I'm creating a new one then.

[namgk]

added some unit tests, however, there are a few things:

• if no path is specified in attachHttpServer, and a mqtt client connect to 'ws://<host>/<any_path>', should the server ignore the <any_path> part and still serve such client as if it was connecting to just 'ws://<host>'?
• was it your intention to always put a mqtt server on port 1883 as default (the case of empty option provided to mosca server)? This doesn't make much sense in the case where you are attaching to an existing http server.

[mcollina]

should be a real dependency, not a devDependency.

[mcollina]

forget about it.

[namgk]

So what do you mean? Would it be ok now then?

[mcollina]

it's ok, my bad.

[mcollina]

if no path is specified in attachHttpServer, and a mqtt client connect to 'ws:///<any_path>', should the server ignore the <any_path> part and still serve such client as if it was connecting to just 'ws://'?

Keep the same behaviour as it was before, like it's now in code.

was it your intention to always put a mqtt server on port 1883 as default (the case of empty option provided to mosca server)? This doesn't make much sense in the case where you are attaching to an existing http server.

Check out https://github.com/mcollina/mosca/blob/master/examples/Server_With_All_Interfaces-Settings.js#L16-L19.

[namgk]

I know it is possible to have server with all interface.

My point is that when I'm attaching to an existing http server, I don't want the port 1883 to be occupied, that's the reason why I'm using mqtt-over-ws.

[mcollina]

You can just specify the interfaces you want to listen to, or none.

[namgk]

the problem is if I specify none, there will still be a mqtt server listens on port 1883.

[namgk]

oh do you mean I should do

var mqttServer = mosca.Server({interface:[]})

?
What I'm using now is

var mqttServer = mosca.Server({})

And this occupies my 1883 port.

[mcollina]

Yes, 'interfaces', not 'interface'.

[namgk]

The following test failed, it's throwing Error: no interface defined

it.only("should not occupy 1883 port while attached to http server", function(done) {
    server = http.createServer();
    mqttServ = new mosca.Server({interfaces:[]});
    mqttServ.attachHttpServer(server);
  });

[mcollina]

Would you mind sending a fix?

[namgk]

sure, I just want to make sure your intention in that case. I'll send another commit.

[namgk]

fixed empty interfaces options, refactored the tests to reflect this.

[namgk]

hi Matteo, do you have a plan to merge? Thanks

[mcollina]

I'm traveling till the end of this week, I will have a look afterwards.

[mcollina]

Good work, just a minor nit.

[mcollina]

why this has been commented? If this is not needed anymore, we should just remove it.

[namgk]

Hi Matteo, that code block was under the assumption that there should be minimum one interface in the option. However this doesn't hold anymore due to the case where you are attaching the mqtt stack on an existing http server.

I deleted that code block.

[mcollina]

perfect, I'll try to assemble a release asap.