This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
fixes #271 #273
Merged
fixes #271 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unique mosca id, fixes moscajs#271
|
Can you please add a unit test for this situation? |
|
We should write a failing test which happens on clustered mosca. have you any test case code sample using clustered mosca? |
|
or we can simulate the environment manipulating |
|
There are some for Ascoltatori, but not for Mosca: https://github.com/mcollina/ascoltatori/blob/master/test/redis_ascoltatore_spec.js#L27-L44. |
|
Would you please check this and merge if it is OK @mcollina |
|
WoW, my typo, commit message should have been "added test for #271" |
mcollina
added a commit
that referenced
this pull request
Jul 12, 2015
|
No problem and thanks for fixing this! |
|
thank you @mcollina |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it simply guards against adding a single (sub,id) multiple times
into _subMatcher