fix qos 0 messages persistance #230
Conversation
new option "store_qos0_messages"
all test passed, no new test new option store_qos0_messages
|
Thanks a million, can you please add a test for those? |
add 4 new simple test for option store_qos0_messages
|
review please... my test pass, in travis websocket fail but i dont touch that, in my machine all test are fine. |
| @@ -67,6 +68,8 @@ var defaults = { | |||
| * It defaults to 1 hour. | |||
| * - `db`, the AbstractLevelDown implementation. | |||
| * - all other `levelup` otions. | |||
| * - `store_qos0_messages` store messages with qos 0, default false | |||
| * like mosquitto option 'queue_qos0_messages', non-standard option | |||
There was a problem hiding this comment.
can you please make the option camelCase?
|
Thanks so much for this PR! I have added some comments, but it is generally good :). |
|
Retained messages are stored, i test it... I will make the option camel case in few das, now i am in vacations, i go back to work next Monday |
|
ups, fix for #231 merged with this PR, revert? |
|
Don't worry, that commit is ok, I get everything merged from here. |
|
I would prefer to have the tests inside https://github.com/mcollina/mosca/blob/master/test/persistence/abstract.js rather than in their own file, specific to Mongo. |
small fix in lib/persistence/abstract.js
|
done, tests for redis, mongo and leveldb. |
fix qos 0 messages persistance
|
Released as 0.28.2. |
i try to fix #229