Fix dataset download location #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j316chuck
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM, can you post a test run?
Also is this syntax correct?
https://github.com/mosaicml/llm-foundry/blob/main/llmfoundry/utils/file_utils.py#L21-L22
Reading the docs it seems the API is a bit different:
https://pytorch.org/docs/stable/distributed.html#torch.distributed.all_gather_object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error in the previous PR by making sure all ranks use the same dataset download location to avoid contention between the ranks operating on the same hugging face dataset.
Example before:
ds-go-away-sl-1-7-egU4ZPExample after:
ds-go-away-sl-2-8-p1nLOh