Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2 in the current codebase.
Is it worth it?
Not sure. It increases the package size by about 80 bytes:
More importantly, perhaps, it makes every loop of
shallowEqual*
do a function call rather than use!==
. If we decide we want this feature, but don't want the cost of the function call, we can instead introduce newshallowEqualCustom*
functions that have the call, but leave the existing functions alone.