Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighter background on terminal #8

Closed
greduan opened this issue Oct 19, 2013 · 15 comments
Closed

Lighter background on terminal #8

greduan opened this issue Oct 19, 2013 · 15 comments
Labels

Comments

@greduan
Copy link

greduan commented Oct 19, 2013

The background color is significantly darker in the GUI version compared to the terminal version. I hope it's just a quick patch. :)

Also remember to update the TODO list in the README file. ;)

MacVim:
screen shot 2013-10-18 at 8 49 09 pm

Terminal:
screen shot 2013-10-18 at 8 48 05 pm

EDIT:
Also I just noticed the line colors are different for both versions as well. Might want to look into that. ;)

@morhetz
Copy link
Owner

morhetz commented Oct 21, 2013

Well, I suppose, it's something wrong with your term settings. You're using iterm2, aren't you? Try setting "Minimal Contrast" slider to low (far left). I don't have a Mac nearby right now, but AFAIR it could be found at Preferences -> Profiles -> Colors. This should work.

@greduan
Copy link
Author

greduan commented Oct 21, 2013

It is already at the lowest contrast. :/

@morhetz
Copy link
Owner

morhetz commented Oct 21, 2013

Hmm, that's strange. What's your "Report terminal type" at Terminal properties, "xterm-256color"?

@greduan
Copy link
Author

greduan commented Oct 21, 2013

Yep. :)

@morhetz
Copy link
Owner

morhetz commented Oct 22, 2013

Crap, the case which I don't have a resolution for. That should be something with iTerm's color space (see [1], [2], [3]).
Well, since it's common problem I should probably redefine colors in gruvbox_256palette_osx.sh to make it more accurate. The bad thing it would be correct for iTerm only, not for Terminal.app. Gimmie about a week to get my hands on.

@greduan
Copy link
Author

greduan commented Oct 22, 2013

No problem. Take your time. :) Maybe you can make an iTerm specific version?

@morhetz
Copy link
Owner

morhetz commented Oct 23, 2013

I probably should. Meanwhile could you test this stuff on Terminal.app just to be sure it's iTerm only case?

@greduan
Copy link
Author

greduan commented Oct 23, 2013

It does have a dark background in Terminal. :/

@morhetz
Copy link
Owner

morhetz commented Oct 23, 2013

So lighter background is iTerm-specific problem only and with Terminal.app background color matches MacVim's one, right?
Not sure if I understood you correctly

@greduan
Copy link
Author

greduan commented Oct 23, 2013

That is correct. However the rest of the colors look off in Terminal, for some reason. :/
screen shot 2013-10-23 at 8 21 06 am

I think testing will be a long process on this one. :/

@morhetz
Copy link
Owner

morhetz commented Oct 23, 2013

Hmm. Looks like gruvbox_256palette_osx.sh doesn't work for Terminal.app at all; so it falls back to incorrect 256-color palette. One more reason to use iTerm2 instead :)
Thanks for all your reports! I'll report progress as soon as I'll get my hands on Mac.

@greduan
Copy link
Author

greduan commented Oct 23, 2013

No problem! Whenever you need me for testing I'm here. :)

@dathinaios
Copy link

Hey thanks for all the work with this :)

Regarding the iTerm colors, I might be wrong but it seems to me that the effect is the same for all colors (see pic). It just seems that the iTerm colors are a bit washed out...

screen shot 2013-11-02 at 16 34 15

EDIT: I did a bit of research and it seems that iTerm (and I think Terminal as well) is using the 'calibrated space' instead of the 'device space' for its colors. Don't ask me what that means, I have no idea.... Here are some links in case you find them useful:

http://apple.stackexchange.com/questions/29487/is-it-possible-to-disable-terminals-automatic-tweaking-of-colors-in-lion
https://github.com/altercation/solarized/tree/master/iterm2-colors-solarized
https://code.google.com/p/iterm2/issues/detail?id=1507

@dathinaios
Copy link

Just in case anyone finds it useful..

What I ended up doing is changing the background value by trial and error until I got it close to what I wanted. This is the result:

screen shot 2014-01-19 at 16 43 08

Left is iTerm2 and right MacVim. The rest of the colors I have actually grown to like better washed out...

If you want to achieve the same result just put the folowing in .zshrc or equivalent and do not call the gruvbox_256palette_osx.sh script. If I recall correctly (I did that a couple of months ago), the only line that is different from the script is echo -ne "\x1bP\x1b]4;235;rgb:20/20/20\a\x1b\\":

echo -ne "\x1bP\x1b]4;236;rgb:32/30/2f\a\x1b\\"
echo -ne "\x1bP\x1b]4;234;rgb:1d/20/21\a\x1b\\"

echo -ne "\x1bP\x1b]4;235;rgb:20/20/20\a\x1b\\"
echo -ne "\x1bP\x1b]4;237;rgb:3c/38/36\a\x1b\\"
echo -ne "\x1bP\x1b]4;239;rgb:50/49/45\a\x1b\\"
echo -ne "\x1bP\x1b]4;241;rgb:66/5c/54\a\x1b\\"
echo -ne "\x1bP\x1b]4;243;rgb:7c/6f/64\a\x1b\\"

echo -ne "\x1bP\x1b]4;244;rgb:92/83/74\a\x1b\\"
echo -ne "\x1bP\x1b]4;245;rgb:92/83/74\a\x1b\\"

echo -ne "\x1bP\x1b]4;229;rgb:fd/f4/c1\a\x1b\\"
echo -ne "\x1bP\x1b]4;223;rgb:eb/db/b2\a\x1b\\"
echo -ne "\x1bP\x1b]4;250;rgb:d5/c4/a1\a\x1b\\"
echo -ne "\x1bP\x1b]4;248;rgb:bd/ae/93\a\x1b\\"
echo -ne "\x1bP\x1b]4;246;rgb:a8/99/84\a\x1b\\"

echo -ne "\x1bP\x1b]4;167;rgb:fb/49/34\a\x1b\\"
echo -ne "\x1bP\x1b]4;142;rgb:b8/bb/26\a\x1b\\"
echo -ne "\x1bP\x1b]4;214;rgb:fa/bd/2f\a\x1b\\"
echo -ne "\x1bP\x1b]4;109;rgb:83/a5/98\a\x1b\\"
echo -ne "\x1bP\x1b]4;175;rgb:d3/86/9b\a\x1b\\"
echo -ne "\x1bP\x1b]4;108;rgb:8e/c0/7c\a\x1b\\"
echo -ne "\x1bP\x1b]4;208;rgb:fe/80/19\a\x1b\\"

echo -ne "\x1bP\x1b]4;88;rgb:9d/00/06\a\x1b\\"
echo -ne "\x1bP\x1b]4;100;rgb:79/74/0e\a\x1b\\"
echo -ne "\x1bP\x1b]4;136;rgb:b5/76/14\a\x1b\\"
echo -ne "\x1bP\x1b]4;24;rgb:07/66/78\a\x1b\\"
echo -ne "\x1bP\x1b]4;96;rgb:8f/3f/71\a\x1b\\"
echo -ne "\x1bP\x1b]4;66;rgb:42/7b/58\a\x1b\\"
echo -ne "\x1bP\x1b]4;130;rgb:af/3a/03\a\x1b\\"

morhetz added a commit that referenced this issue Apr 7, 2014
@morhetz
Copy link
Owner

morhetz commented Apr 7, 2014

Doh. I've finally did it. Recent script version needs some testing since it's sh//printf based, but colors should be exactly the same now.

@morhetz morhetz closed this as completed Apr 7, 2014
minodisk pushed a commit to minodisk/gruvbox that referenced this issue Oct 29, 2014
Splinter1984 pushed a commit to Splinter1984/gruvbox that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants