-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Styled Components to 4.0.2, Babel to 7.1.2 #14
Conversation
It looks good! I will try to merge this in later today! Are we sure with peerDep versions? Many people aren't at latest React and might get a little warning from NPM / Yarn cli. |
Thanks : ). And if they want to use the latest styled-components, they should be, cause there react / react-dom is a dev-Dependency: https://github.com/styled-components/styled-components/blob/master/package.json - so I guess, we are in the clear. |
Good job @timhagn , I'm waiting this merge with trepidation :) |
@aureliome Thanks : )! Did you choose the word "trepidation" for Halloween? Cause translated to German it would mean something like "anxiety", "fearfulness" or the like ^^. One never stops learning. |
I'm really interested in this merge as well ! I'm using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
First of all, you did a great job! Thank you. 🥇
-
I have a few remarks - hope it's clear, but feel free to discuss 👍
-
p.s. do we need package-lock.json here? I think yarn.lock is enough. ❓
For all waiting for an answer, my main workstations Motherboard crashed yesterday and I'm just trying to get back on track with my Dev-Laptop -.- |
No worries @timhagn! It's open source and we're here to learn and have fun 👋 hope the machine gets alright soon! |
881d4e7
to
57b4f99
Compare
Although my main workstation is still down: |
I have removed p.s. @morajabi I think it's ready to merge |
Any updates on this merge? Just asking ; ). |
First, my apologies for the merging taking so long! It's now published as v2.1.0 🎷 |
Nice! That's greats news on the merge and me now being a contributor. Thanks a lot, gonna use it responsibly : ). And so happy, that I now don't have to integrate my repo in my package.json ^^. |
@ApacheEx Forgot to push the GH tags, but how does that make the build fail? I thought NPM doesn't depend on these. |
Wait, I think I found the cause. |
yeah, works now. Thank you guys |
@timhagn Someone forgot to run |
First of all, great module, I really like using it with Styled Components!
In preparation for writing the tests with jest, it came to me, that some dependencies were
quite outdated - especially now that styled-components is @ 4.0.2.
So I did the following:
And some smaller changes, as you can see in the commits.
With all this I wanted to:
I tested the build process and integrated it in a gatsby page with no problems occuring.
This will prepare for:
Tackling Issue #1 - If it's at your convenience.