Do not ignore the exact parameter in the search method
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingosticks
added
C-enhancement
kingosticks
added a commit
to kingosticks/mopidy-spotify
that referenced
this pull request
Dec 20, 2023
* Do not ignore the `exact` parameter in the `search` method * Reformat to comply with Flake8 and Black * Correct additional tests * flake8 fix Co-authored-by: Nick Steel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
sp_search_queryfunction has always added double quotes around the query and double quotes instruct the Spotify API to perform exact matching, thesearchfunction has always performed exact matching, regardless of whetherexactisFalseorTrue.mopidy-spotify/mopidy_spotify/translator.py
Lines 283 to 286 in a4aa63a
Since exact matching has been the only behavior (and therefore the default behavior) since the inception of Mopidy-Spotify, it could be sensible to keep exact matching as the default behavior. However, according to the Mopidy documentation, inexact matching is supposed to be the default behavior.