Ignore parts of web responses with a None URI. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 13 13
Lines 1206 1206
=======================================
Hits 1166 1166
Misses 40 40
Continue to review full report at Codecov.
|
4 tasks
|
It would be preferable to remove all None values from the a web response but seeing as we don't go near half the fields that seems a lot of extra work. |
kingosticks
force-pushed
the
fix/web-types-with-none-uri
branch
from
23b28f1 to
29ebee6
Compare
We can't do anything sensible without a URI so ignore anything that doesn't have one. This occurs in the album and artist fields within local Spotify tracks (from a playlist).
kingosticks
force-pushed
the
fix/web-types-with-none-uri
branch
from
29ebee6 to
a4aa63a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't do anything sensible without a URI so also ignore anything where it is
None. This occurs in the album and artist fields within local Spotify tracks (from a playlist).Without this we try and translate the artist and album fields, which isn't useful and in the case of changes in #287 actually causes an exception.