Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all tracks in "Your Music", "Playlists" and "Top Lists" #279

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

girst
Copy link
Member

@girst girst commented Oct 4, 2020

fixes #256

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #279 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          13       13           
  Lines        1191     1194    +3     
=======================================
+ Hits         1151     1154    +3     
  Misses         40       40           
Impacted Files Coverage Δ
mopidy_spotify/browse.py 91.30% <100.00%> (+0.07%) ⬆️
mopidy_spotify/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77a73b...5b35448. Read the comment docs.

@girst girst force-pushed the bug256 branch 5 times, most recently from 40c086f to 3fcbacf Compare October 4, 2020 15:46
@girst girst force-pushed the bug256 branch 3 times, most recently from e8bc47e to 71d1a03 Compare October 30, 2020 13:30
@girst girst changed the title Load all entries of "Your Music" Load all tracks in "Your Music", "Playlists" and "Top Lists" Oct 30, 2020
Copy link
Member

@kingosticks kingosticks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's close to being worth writing a helper to flatten these pages of results. It would be nice if the mocked results could return multiple pages (including maybe some empty ones) to better test the new code. But it does of course all work just fine. I did find it a little slow for my larger "your music" list to load and I would guess that's going to be very noticeable for people on slow machines. We'd need to do some "repagination" to address that but we can solve that another day if it proves to be a problem.

@girst
Copy link
Member Author

girst commented Nov 2, 2020 via email

@girst girst force-pushed the bug256 branch 2 times, most recently from 5cd4b2b to cc0579c Compare November 3, 2020 15:14
@girst
Copy link
Member Author

girst commented Nov 3, 2020 via email

@kingosticks kingosticks merged commit 7bacf57 into mopidy:master Nov 3, 2020
@kingosticks
Copy link
Member

This is great - thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Your Music" limited to 20 results
2 participants