Soaku gapless playback #277
Conversation
This fixes the tests. Also added testing of the held buffer.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 96.64% 96.67% +0.03%
==========================================
Files 13 13
Lines 1191 1203 +12
==========================================
+ Hits 1151 1163 +12
Misses 40 40
Continue to review full report at Codecov.
|
|
There is still https://github.com/mopidy/mopidy-spotify/pull/277/files#diff-d09e8ce8f0a316832307028fe46a8319R202 to think about. I think it's actually OK and the None condition is handled by our appsrc. |
|
Haven't noticed your PR before. I'm glad you fixed it and I think your solution should be okay. |
mopidy_spotify/playback.py
Outdated
| # Last audio data sent to the buffer, currently on hold. This data is held | ||
| # because libspotify sends a single empty buffer before ending the track. It is | ||
| # discarded the moment a new track starts so a smooth transition between songs | ||
| # can be made. |
There was a problem hiding this comment.
Stray comment? Move into __init__()?
|
After an hour or so on video with @kingosticks live-coding now, we've:
Should be ready to merge as soon as Nick is a bit more awake and confident enough :-) |
kingosticks
force-pushed
the
Soaku-gapless-playback
branch
from
a6af848 to
0ac120d
Compare
|
This is great news! Thank you! |
This is #269 with the remaining CI fixes. And also with the held buffer changed from a global to an instance variable as the
music_delivery_callbacktests were no longer doing the right thing.