Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message on mobile below the screen #16

Closed
GrimLink opened this issue Sep 3, 2020 · 2 comments · Fixed by #21
Closed

Message on mobile below the screen #16

GrimLink opened this issue Sep 3, 2020 · 2 comments · Fixed by #21
Assignees
@HHarsevoord @poespas @orofabio
Labels
enhancement New feature or request question Further information is requested

Comments

@GrimLink
Copy link
Contributor

GrimLink commented Sep 3, 2020

It is better show the addto notification on mobile below, on the screen.
Similar to other mobile notifications as also seen in https://material.io/components/snackbars.

If everyone is okay with this I will create a PR for this
@GrimLink GrimLink added enhancement New feature or request question Further information is requested labels Sep 3, 2020
@GrimLink
Copy link
Contributor Author

GrimLink commented Sep 3, 2020 •
edited
Loading

Screenshot 2020-09-03 at 11 33 29

Example DKW

@orofabio
Copy link
Member

orofabio commented Sep 9, 2020

Great suggestion! My only feedback would be to have a little offset on the sides/bottom, lets say 10px or 20px.

GrimLink added a commit that referenced this issue Dec 17, 2020
@GrimLink
ADD: Postition option for xs and md, closes #16
9305ec8
@GrimLink GrimLink mentioned this issue Dec 17, 2020
Merged
GrimLink added a commit that referenced this issue Dec 18, 2020
@GrimLink
Merge pull request #21 from mooore-digital/feature/FRO-164-add-to-car…
2b3d3c8 
…t-mobile-style

Feature - add to cart mobile style, closes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HHarsevoord HHarsevoord

@poespas poespas

@orofabio orofabio

Labels
enhancement New feature or request question Further information is requested
Milestone
No milestone
4 participants
@HHarsevoord @GrimLink @poespas @orofabio