Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIP-O13 #484

Merged
merged 16 commits into from
Mar 4, 2025
Merged

MIP-O13 #484

merged 16 commits into from
Mar 4, 2025

Conversation

ElliotFriedman
Copy link
Collaborator

MIP-O13 accepts ownership of the newly deployed Moonwell USDC Vault on Optimism.

Vault: https://optimistic.etherscan.io/address/0x3520e1a10038131a3c00bf2158835a75e929642d

USDC Address: https://optimistic.etherscan.io/address/0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85

Fee splitter: https://optimistic.etherscan.io/address/0x50d3E1BD46235ce1cCf133a74e10cfdc58d49E90

@ElliotFriedman
Copy link
Collaborator Author

command:

DO_VALIDATE=true DO_PRINT=true DO_BUILD=true DO_RUN=true forge script proposals/mips/mip-o13/mip-o13.sol:mipo13

output:


----------------- Proposal Actions ------------------

  0x79ba5097
  Proposal type: Optimism  

----------------- Proposal Calldata ------------------

  0x7d5e81e2000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000003800000000000000000000000000000000000000000000000000000000000000001000000000000000000000000c8e2b0cd52cf01b0ce87d389daa3d414d4ce29f300000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000204b19a437e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000c8000000000000000000000000000000000000000000000000000000000000018000000000000000000000000017c9ba3fda7ec71ccfd75f978ef31e21927aff3d000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000010000000000000000000000003520e1a10038131a3c00bf2158835a75e929642d0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000479ba509700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001aa423204d49502d4f31333a20416363657074204f776e657273686970206f6620466c616773686970204d6f6f6e77656c6c2055534443205661756c74206f6e204f50204d61696e6e65740a0a2a2a417574686f722873293a2a2a20426c6f636b20416e616c697469636120616e6420422e50726f746f636f6c202a2a52656c617465642044697363757373696f6e733a2a2a0a5b4d6f6f6e77656c6c204d6574614d6f7270686f205661756c7473202d204e6578742047656e2044654669204c656e64696e675d2868747470733a2f2f666f72756d2e6d6f6f6e77656c6c2e66692f742f696e74726f647563696e672d6d6f6f6e77656c6c2d6d6574616d6f7270686f2d7661756c74732d6e6578742d67656e2d646566692d6c656e64696e672f3936302f313629200a5b5375706572636861696e20457870616e73696f6e2050726f706f73616c5d282068747470733a2f2f666f72756d2e6d6f6f6e77656c6c2e66692f742f70726f706f73616c2d746f2d6c61756e63682d6d6f6f6e77656c6c2d666c6167736869702d757364632d7661756c742d6f6e2d4f50204d61696e6e65742f31353430290a2a2a5375626d697373696f6e20446174653a2a2a204d6172636820332c20323032350a0a23232050726f706f73616c2053756d6d6172790a0a466f6c6c6f77696e67207468652073756363657373206f66204d6f6f6e77656c6c20466c61677368697020616e642046726f6e74696572207661756c7473206f6e20426173652c2077686963680a63757272656e746c7920686f6c64206d6f7265207468616e202438354d20696e20746f74616c2076616c7565206c6f636b6564202854564c29206163726f7373204554482c20555344432c0a455552432c20616e642063624254432c20746869732070726f706f73616c207365656b7320746f20657870616e64206f75722073747261746567696320666f6f747072696e742062790a616363657074696e67206f776e657273686970206f662074686520466c616773686970204d6f6f6e77656c6c2055534443205661756c74206f6e204f50204d61696e6e657420284f500a4d61696e6e6574292e0a0a57697468207468697320696e69746961746976652c2077652061696d20746f20617474726163742055534443206465706f7369746f72732c2064656570656e206e6574776f726b0a6c697175696469747920666f72207468697320696d706f7274616e7420737461626c65636f696e2c20616e6420667572746865722065737461626c697368204d6f6f6e77656c6c20617320610a6c656164696e6720636f6e7472696275746f7220696e20746865204d6f7270686f20616e64205375706572636861696e2065636f73797374656d732e2054686520555344430a7661756c742069732070726f706f7365642077697468207468652073616d6520726f6c652061737369676e6d656e74732061732074686f73652070726573656e7420666f720a6578697374696e6720466c616773686970207661756c74732e20412031352520706572666f726d616e6365206665652077696c6c20626520696d706c656d656e7465642c20776974680a746865204d6f6f6e77656c6c2044414f2773207368617265206265696e6720646972656374656420746f204d6f6f6e77656c6c2773205553444320436f7265204d61726b65740a70726f746f636f6c2072657365727665732e0a0a54686973204d49502070726f706f7365733a0a0a312e20416363657074696e67206f776e657273686970206f662074686520466c616773686970204d6f6f6e77656c6c2055534443205661756c742c20657870616e64696e67204d6f6f6e77656c6c27730a20204d6f7270686f207661756c74206f66666572696e6773206f6e204f50204d61696e6e65742e0a0a2323204261636b67726f756e6420616e6420526174696f6e616c650a0a4c6173742073756d6d65722c205b4d49502d4232315d2868747470733a2f2f626f617264726f6f6d2e696f2f6d6f6f6e77656c6c2f70726f706f73616c2f63484a766347397a5957773662573976626e646c624777366232356a6147467062693131634764795957526c4f6a497829206b69636b6564206f6666204d6f6f6e77656c6c2044414f277320636f6c6c61626f726174696f6e207769746820426c6f636b0a416e616c697469636120616e6420422e50726f746f636f6c2c20706176696e67207468652077617920666f722074686520646576656c6f706d656e74206f6620746865204d6f6f6e77656c6c0a466c61677368697020616e642046726f6e7469657220736572696573206f66204d6f7270686f207661756c74732e20546f6461792c207468657365207661756c7473207374616e6420616d6f6e670a746865206c6172676573742062792054564c20696e2074686520426173652065636f73797374656d2c20686967686c69676874696e67207468656972207374726f6e672061646f7074696f6e20616e640a7369676e69666963616e63652e0a0a4275696c64696e67206f6e2074686973207375636365737366756c206d6f64656c2c2077652070726f706f736520657870616e64696e6720746f204f50204d61696e6e657420746f20617474726163740a6e6577206361706974616c20616e642055534443207573657273207365656b696e67207269736b2d61646a7573746564207969656c642e204279206265696e672074686520666972737420746f0a6f6666657220612066756c6c7920696e7465677261746564204d6f7270686f207661756c7420657870657269656e6365206f6e204f50204d61696e6e6574e28094776865726520746865204d6f7270686f0a66726f6e74656e642069732063757272656e746c7920756e617661696c61626c65e28094776520706f736974696f6e206f757273656c76657320746f2063617074757265206561726c79206d61726b65740a736861726520616e642070617665207468652077617920666f722066757475726520657870616e73696f6e206163726f7373205375706572636861696e2d616c69676e6564206e6574776f726b732e0a0a546869732070726f706f73616c20616c69676e73207769746820746865204d6f7270686f204576657279776865726520657870616e73696f6e20706c616e2c2077686963682061696d7320746f0a65737461626c697368204d6f7270686f20696e667261737472756374757265206163726f7373206d756c7469706c6520457468657265756d204c3120616e64204c32206e6574776f726b732c0a696e636c7564696e67204f50204d61696e6e65742e205468697320636f756c6420626520746865206669727374206f66206d756c7469706c65207661756c7473206c61756e636865642062790a4d6f6f6e77656c6c2044414f20616e6420426c6f636b20416e616c79746963612f422e50726f746f636f6c206f6e205375706572636861696e2d616c69676e6564206e6574776f726b732c0a737570706f7274696e67206f75722062726f6164657220766973696f6e206f66207363616c696e6720457468657265756d206c656e64696e6720696e667261737472756374757265206163726f73730a746865205375706572636861696e2e0a0a232320436f6e7472616374204164647265737365730a0a2d202a2a5553444320546f6b656e3a2a2a0a205b3078306232433633396335333338313366344161394437383337434166363236353364303937466638355d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307830623243363339633533333831336634416139443738333743416636323635336430393746663835290a2d202a2a5553444320466c616773686970205661756c743a2a2a0a205b3078333532306531613130303338313331613363303062663231353838333561373565393239363432645d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307833353230653161313030333831333161336330306266323135383833356137356539323936343264290a2d202a2a5553444320466c616773686970205661756c74204665652053706c69747465723a2a2a0a205b3078353064334531424434363233356365316343663133336137346531306366646335386434394539305d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307835306433453142443436323335636531634366313333613734653130636664633538643439453930290a0a2323205661756c7420436f6e66696775726174696f6e20616e6420526f6c65730a0a546865205553444320466c616773686970205661756c742077696c6c20626520636f6e6669677572656420617320666f6c6c6f77733a0a0a2d202a2a4f776e65723a2a2a204d6f6f6e77656c6c2044414f202876696120746865204d6f6f6e77656c6c2054656d706f72616c20476f7665726e6f7220636f6e7472616374290a2d202a2a43757261746f723a2a2a20426c6f636b20416e616c6974696361202620422e50726f746f636f6c0a2d202a2a416c6c6f6361746f723a2a2a20426c6f636b20416e616c6974696361202620422e50726f746f636f6c0a2d202a2a477561726469616e3a2a2a204d6f6f6e77656c6c20536563757269747920436f756e63696c0a2d202a2a54696d656c6f636b20706572696f643a2a2a203420646179730a2d202a2a5661756c74206e616d653a2a2a204d6f6f6e77656c6c20466c6167736869702055534443205661756c740a2d202a2a53796d626f6c3a2a2a206d77555344430a0a23232050726f706f736564204d61726b6574730a0a426c6f636b20416e616c6974696361206861732070726f706f736564206c697374696e672074776f206d61726b65747320666f72207468652055534443207661756c74206f6e204f50204d61696e6e65743a0a0a232323207773744554482f55534443204d61726b65740a0a2d202a2a4c6f616e20746f6b656e3a2a2a2055534443202d0a205b3078306232633633396335333338313366346161396437383337636166363236353364303937666638355d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307830623263363339633533333831336634616139643738333763616636323635336430393766663835290a2d202a2a436f6c6c61746572616c20746f6b656e3a2a2a20777374455448202d0a205b3078314633326231633233343535333863306336663538326643423032323733396334413139344562625d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307831463332623163323334353533386330633666353832664342303232373339633441313934456262290a2d202a2a4f7261636c653a2a2a204d6f7270686f20436861696e6c696e6b202d0a205b3078316563343038443431333136383666373237463346643632343543463835426335633944414437305d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307831656334303844343133313638366637323746334664363234354346383542633563394441443730290a2d202a2a49524d3a2a2a2041646170746976652043757276652049524d202d0a205b3078386344373041384633393934323834353662323935343642433564426531306162366130366566365d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307838634437304138463339393432383435366232393534364243356442653130616236613036656636290a2d202a2a4c4c54563a2a2a203836250a2d202a2a537570706c79204361703a2a2a2033304d20555344430a0a23232320574554482f55534443204d61726b65740a0a2d202a2a4c6f616e20746f6b656e3a2a2a2055534443202d0a205b3078306232633633396335333338313366346161396437383337636166363236353364303937666638355d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307830623263363339633533333831336634616139643738333763616636323635336430393766663835290a2d202a2a436f6c6c61746572616c20746f6b656e3a2a2a2057455448202d0a205b3078343230303030303030303030303030303030303030303030303030303030303030303030303030365d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307834323030303030303030303030303030303030303030303030303030303030303030303030303036290a2d202a2a4f7261636c653a2a2a204d6f7270686f20436861696e6c696e6b202d0a205b3078316563343038443431333136383666373237463346643632343543463835426335633944414437305d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307831656334303844343133313638366637323746334664363234354346383542633563394441443730290a2d202a2a49524d3a2a2a2041646170746976652043757276652049524d202d0a205b3078386344373041384633393934323834353662323935343642433564426531306162366130366566365d2868747470733a2f2f6f7074696d69737469632e65746865727363616e2e696f2f616464726573732f307838634437304138463339393432383435366232393534364243356442653130616236613036656636290a2d202a2a4c4c54563a2a2a203836250a2d202a2a537570706c79204361703a2a2a2033304d20555344430a0a5468657365206d61726b6574206c697374696e67732077657265206578656375746564206f6e2046656272756172792031392c20323032352c2061742031303a35303a333120414d202b5554430a616e642031303a35303a313720414d202b55544320726573706563746976656c792e0a0a232320506572666f726d616e63652046656520616e6420496e63656e74697665730a0a546869732070726f706f73616c20696d706c656d656e74732061202a2a31352520706572666f726d616e6365206665652a2a20666f7220746865205553444320466c616773686970205661756c742c0a746f2062652073706c6974206265747765656e20426c6f636b20416e616c69746963612f422e50726f746f636f6c20616e6420746865204d6f6f6e77656c6c2044414f2e205468650a4d6f6f6e77656c6c2044414f277320706f7274696f6e2077696c6c20626520616464656420746f204d6f6f6e77656c6c2773205553444320436f7265204d61726b65742070726f746f636f6c0a7265736572766573206f6e204f50204d61696e6e65742e0a0a4e6f7465207468617420746865206c61756e6368206f662074686973206e6577207661756c7420646f6573206e6f7420696d706c792061206e65772057454c4c20746f6b656e206772616e7420666f720a6c697175696469747920696e63656e74697665732e20486f77657665722c207468657265206d6179206265206f70706f7274756e697469657320746f2072656365697665204f500a696e63656e7469766573207468726f75676820696e697469617469766573207375636820617320536561736f6e2037204f50204d61696e6e6574204772616e747320436f756e63696c204772616e74732c0a776869636820666f637573206f6e20626f6c73746572696e67205375706572636861696e2054564c2e0a0a232320496d706c656d656e746174696f6e0a0a496620746869732070726f706f73616c207061737365732c2074686520666f6c6c6f77696e67206f6e636861696e20616374696f6e732077696c6c2062652065786563757465643a0a0a312e204d6f6f6e77656c6c2044414f2077696c6c20616363657074206f776e657273686970206f6620746865204d6f6f6e77656c6c20466c6167736869702055534443205661756c74206f6e0a20204f50204d61696e6e65742e0a0a232320566f74696e67204f7074696f6e730a0a2d202a2a466f723a2a2a20416363657074206f776e657273686970206f66204d6f6f6e77656c6c20466c6167736869702055534443204d6f7270686f207661756c74206f6e204f50204d61696e6e65742e0a2d202a2a416761696e73743a2a2a2052656a656374206f776e657273686970206f66204d6f6f6e77656c6c20466c6167736869702055534443204d6f7270686f207661756c74206f6e0a204f50204d61696e6e65742e0a2d202a2a4162737461696e2a2a0a0a232320436f6e636c7573696f6e0a0a546865206164646974696f6e206f662061205553444320466c616773686970205661756c7420726570726573656e747320612073747261746567696320657870616e73696f6e206f660a4d6f6f6e77656c6c2773206f66666572696e6773206f6e204f50204d61696e6e65742e204279206c657665726167696e67204d6f7270686f20696e66726173747275637475726520616e64207468650a7269736b206d616e6167656d656e7420657870657274697365206f6620426c6f636b20416e616c697469636120616e6420422050726f746f636f6c2c2077652061696d20746f207265706c69636174650a7468652073756363657373206f66206f7572206578697374696e67207661756c747320616e642074617020696e746f207468652067726f77696e672064656d616e6420666f72207969656c640a6f70706f7274756e6974696573206f6e204f50204d61696e6e65742e0a0a4279206265696e672074686520666972737420746f206f666665722061204d6f7270686f2d696e7465677261746564206c656e64696e6720657870657269656e6365206f6e204f50204d61696e6e65742c0a4d6f6f6e77656c6c206861732074686520706f74656e7469616c20746f2063617074757265206561726c79206d61726b657420736861726520616e6420657870616e64206974730a696e666c75656e6365206163726f737320746865205375706572636861696e2e20417070726f76696e6720746869732070726f706f73616c2077696c6c20657870616e64207661756c740a6f66666572696e67732c2061747472616374206e65772075736572732c20616e64207265696e666f726365204d6f6f6e77656c6c277320706f736974696f6e2061732061206c656164696e670a4465466920617070206f6e20746865205375706572636861696e2e00000000000000000000000000000000000000000000000000000000

Copy link

openzeppelin-code bot commented Mar 3, 2025

MIP-O13

Generated at commit: e810339fc00f4aee7d66be56ae267ee0bb5b4cf8

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
4
0
12
45
64
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

{
"addr": "0x50d3E1BD46235ce1cCf133a74e10cfdc58d49E90",
"isContract": true,
"name": "USDC_METAMORPHO_FEE_SPLITTER"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed vault and mToken addresses are correct


This MIP proposes:

1. Accepting ownership of the Flagship Moonwell USDC Vault, expanding Moonwell's
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to use numbering if is only 1 item

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, but prop text was already greenlit by Eli so I didn't want to make any more changes

Comment on lines +125 to +131
## Voting Options

- **For:** Accept ownership of Moonwell Flagship USDC Morpho vault on OP
Mainnet.
- **Against:** Reject ownership of Moonwell Flagship USDC Morpho vault on OP
Mainnet.
- **Abstain**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move below conclusion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, but prop text was already greenlit by Eli so I didn't want to make any more changes


If this proposal passes, the following onchain actions will be executed:

1. Moonwell DAO will accept ownership of the Moonwell Flagship USDC Vault on OP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove number

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, but prop text was already greenlit by Eli so I didn't want to make any more changes

@ElliotFriedman
Copy link
Collaborator Author

proposal is onchain: https://moonwell.fi/governance/proposal/moonbeam?id=163

Copy link

github-actions bot commented Mar 4, 2025

Compiling 4 files with Solc 0.8.19
Solc 0.8.19 finished in 9.10ms
Compiler run successful!
Script ran successfully.
Gas used: 37642240

If you wish to simulate on-chain transactions pass a RPC URL.

@anajuliabit
Copy link
Collaborator

LGTM

@anajuliabit anajuliabit merged commit 383516f into main Mar 4, 2025
23 checks passed
@anajuliabit anajuliabit deleted the feat/mip-o13 branch March 4, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants