Physical deletion of files after deletion #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting files from storage when deleting from edit form
Deleting Files within Relationships. New method for deleting files. New flag for deleting files
Remove all files and empty directories when deleting a resource. New event afterDelete. Implementation of this event in the File field and the HasOneOrMany field
Removing files from a resource during mass deletion
Mass delete testing
Fix HasOne when deleting files
lee-to
requested changes
May 18, 2023
Fixes after review. New trait FileDeleteableTrait. Added flag to remove directories
Methods deleteFile and checkForDeletion became public. Review Fixes.
Deletion with the removable flag in the HasOne field. New methods for getting file fields in the Fields class
Tests for getting only file fields from the Fields class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the files are physically deleted. Added a flag to the File field $isDeleteFiles. Added afterDelete method to fields. The afterDelete method is overridden in the File field and HasOneOrMany trait