Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Enable Pkl without an experiment. #1804

Merged
merged 4 commits into from
Jan 29, 2025
Merged

new: Enable Pkl without an experiment. #1804

merged 4 commits into from
Jan 29, 2025

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Jan 28, 2025

No description provided.

Copy link

Run report for d8d7511c (ubuntu-latest, 22)

Total time: 2m 57s | Comparison time: 3m 21s | Estimated savings: 24.3s (12.0% faster)

Action Time Status Info
🟩 SyncWorkspace 237.1ms Passed
🟩 SetupToolchain(node:~22) 25.7s Passed
🟩 SyncProject(node, types) 4ms Passed
🟩 SyncProject(node, runtime) 3.7ms Passed
🟩 SyncProject(node, website) 4.2ms Passed
🟩 InstallWorkspaceDeps(node:~22) 41.6s Passed
🟦 RunTask(types:build) 1.5s Cached
🟦 RunTask(runtime:build) 416.3ms Cached
🟦 RunTask(website:typecheck) 120ms Cached
🟦 RunTask(website:test) 172.8ms Cached
🟩 RunTask(website:lint) 13.9s Passed
🟩 RunTask(website:format) 14s Passed
🟩 RunTask(website:build) 1m 47s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 22
Touched files
CHANGELOG.md
Cargo.lock
Cargo.toml
crates/app/Cargo.toml
crates/app/src/app.rs
crates/app/src/app_error.rs
crates/app/src/session.rs
crates/app/src/systems/analyze.rs
crates/cli/tests/snapshots/task_test__can_show_internal.snap
crates/cli/tests/snapshots/task_test__shows_inputs.snap
crates/cli/tests/snapshots/task_test__shows_outputs.snap
crates/common/src/helpers.rs
crates/common/src/lib.rs
crates/config/src/config_finder.rs
crates/config/src/config_loader.rs
crates/config/src/inherited_tasks_config.rs
crates/config/tests/inherited_tasks_config_test.rs
crates/config/tests/project_config_test.rs
crates/config/tests/template_config_test.rs
crates/config/tests/toolchain_config_test.rs
crates/config/tests/workspace_config_test.rs
crates/project-graph/tests/project_graph_test.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/tasks_builder_test.rs
justfile
website/blog/2024-10-07_moon-v1.29.mdx
website/docs/config/project.mdx
website/docs/config/tasks.mdx
website/docs/config/template.mdx
website/docs/config/toolchain.mdx
website/docs/config/workspace.mdx
website/docs/guides/pkl-config.mdx
website/sidebars.ts

Copy link

Run report for d8d7511c (ubuntu-latest, 18)

Total time: 3m 8s | Comparison time: 3m 36s | Estimated savings: 28.2s (13.0% faster)

Action Time Status Info
🟩 SyncWorkspace 386ms Passed
🟩 SetupToolchain(node:~18) 24s Passed
🟩 SyncProject(node, types) 3.7ms Passed
🟩 SyncProject(node, runtime) 3.6ms Passed
🟩 SyncProject(node, website) 3.9ms Passed
🟩 InstallWorkspaceDeps(node:~18) 43.4s Passed
🟦 RunTask(types:build) 1.7s Cached
🟦 RunTask(runtime:build) 581.5ms Cached
🟦 RunTask(website:typecheck) 184.1ms Cached
🟦 RunTask(website:test) 282.8ms Cached
🟩 RunTask(website:lint) 15s Passed
🟩 RunTask(website:format) 15.2s Passed
🟩 RunTask(website:build) 1m 58s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
CHANGELOG.md
Cargo.lock
Cargo.toml
crates/app/Cargo.toml
crates/app/src/app.rs
crates/app/src/app_error.rs
crates/app/src/session.rs
crates/app/src/systems/analyze.rs
crates/cli/tests/snapshots/task_test__can_show_internal.snap
crates/cli/tests/snapshots/task_test__shows_inputs.snap
crates/cli/tests/snapshots/task_test__shows_outputs.snap
crates/common/src/helpers.rs
crates/common/src/lib.rs
crates/config/src/config_finder.rs
crates/config/src/config_loader.rs
crates/config/src/inherited_tasks_config.rs
crates/config/tests/inherited_tasks_config_test.rs
crates/config/tests/project_config_test.rs
crates/config/tests/template_config_test.rs
crates/config/tests/toolchain_config_test.rs
crates/config/tests/workspace_config_test.rs
crates/project-graph/tests/project_graph_test.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/tasks_builder_test.rs
justfile
website/blog/2024-10-07_moon-v1.29.mdx
website/docs/config/project.mdx
website/docs/config/tasks.mdx
website/docs/config/template.mdx
website/docs/config/toolchain.mdx
website/docs/config/workspace.mdx
website/docs/guides/pkl-config.mdx
website/sidebars.ts

Copy link

Run report for d8d7511c (ubuntu-latest, 20)

Total time: 3m 10s | Comparison time: 3m 30s | Estimated savings: 20s (9.5% faster)

Action Time Status Info
🟩 SyncWorkspace 238.2ms Passed
🟩 SetupToolchain(node:~20) 23.6s Passed
🟩 SyncProject(node, types) 3.6ms Passed
🟩 SyncProject(node, runtime) 3.5ms Passed
🟩 SyncProject(node, website) 3.6ms Passed
🟩 InstallWorkspaceDeps(node:~20) 43.8s Passed
🟦 RunTask(types:build) 1s Cached
🟦 RunTask(runtime:build) 358.7ms Cached
🟦 RunTask(website:typecheck) 121.1ms Cached
🟦 RunTask(website:test) 180.6ms Cached
🟩 RunTask(website:lint) 14.9s Passed
🟩 RunTask(website:format) 15.2s Passed
🟩 RunTask(website:build) 2m 1s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
CHANGELOG.md
Cargo.lock
Cargo.toml
crates/app/Cargo.toml
crates/app/src/app.rs
crates/app/src/app_error.rs
crates/app/src/session.rs
crates/app/src/systems/analyze.rs
crates/cli/tests/snapshots/task_test__can_show_internal.snap
crates/cli/tests/snapshots/task_test__shows_inputs.snap
crates/cli/tests/snapshots/task_test__shows_outputs.snap
crates/common/src/helpers.rs
crates/common/src/lib.rs
crates/config/src/config_finder.rs
crates/config/src/config_loader.rs
crates/config/src/inherited_tasks_config.rs
crates/config/tests/inherited_tasks_config_test.rs
crates/config/tests/project_config_test.rs
crates/config/tests/template_config_test.rs
crates/config/tests/toolchain_config_test.rs
crates/config/tests/workspace_config_test.rs
crates/project-graph/tests/project_graph_test.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/tasks_builder_test.rs
justfile
website/blog/2024-10-07_moon-v1.29.mdx
website/docs/config/project.mdx
website/docs/config/tasks.mdx
website/docs/config/template.mdx
website/docs/config/toolchain.mdx
website/docs/config/workspace.mdx
website/docs/guides/pkl-config.mdx
website/sidebars.ts

Copy link

Run report for d8d7511c (windows-latest, 18)

Total time: 1m 53s | Comparison time: 5m 18s | Estimated savings: 3m 25s (64.4% faster)

Action Time Status Info
🟩 SyncWorkspace 328.5ms Passed
🟩 SetupToolchain(node:~18) 26s Passed
🟩 SyncProject(node, types) 6.1ms Passed
🟩 SyncProject(node, runtime) 4.8ms Passed
🟩 SyncProject(node, website) 5ms Passed
🟩 InstallWorkspaceDeps(node:~18) 1m 1s Passed
🟦 RunTask(types:build) 1.9s Cached
🟦 RunTask(runtime:build) 659.7ms Cached
🟦 RunTask(website:typecheck) 272.5ms Cached
🟦 RunTask(website:lint) 312.8ms Cached
🟦 RunTask(website:test) 369.5ms Cached
🟩 RunTask(website:format) 11.4s Passed
🟦 RunTask(website:build) 22.5s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
CHANGELOG.md
Cargo.lock
Cargo.toml
crates/app/Cargo.toml
crates/app/src/app.rs
crates/app/src/app_error.rs
crates/app/src/session.rs
crates/app/src/systems/analyze.rs
crates/cli/tests/snapshots/task_test__can_show_internal.snap
crates/cli/tests/snapshots/task_test__shows_inputs.snap
crates/cli/tests/snapshots/task_test__shows_outputs.snap
crates/common/src/helpers.rs
crates/common/src/lib.rs
crates/config/src/config_finder.rs
crates/config/src/config_loader.rs
crates/config/src/inherited_tasks_config.rs
crates/config/tests/inherited_tasks_config_test.rs
crates/config/tests/project_config_test.rs
crates/config/tests/template_config_test.rs
crates/config/tests/toolchain_config_test.rs
crates/config/tests/workspace_config_test.rs
crates/project-graph/tests/project_graph_test.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/tasks_builder_test.rs
justfile
website/blog/2024-10-07_moon-v1.29.mdx
website/docs/config/project.mdx
website/docs/config/tasks.mdx
website/docs/config/template.mdx
website/docs/config/toolchain.mdx
website/docs/config/workspace.mdx
website/docs/guides/pkl-config.mdx
website/sidebars.ts

Copy link

Run report for d8d7511c (windows-latest, 22)

Total time: 1m 47s | Comparison time: 4m 28s | Estimated savings: 2m 41s (60.0% faster)

Action Time Status Info
🟩 SyncWorkspace 315.5ms Passed
🟩 SetupToolchain(node:~22) 30.4s Passed
🟩 SyncProject(node, types) 6.2ms Passed
🟩 SyncProject(node, runtime) 4.7ms Passed
🟩 SyncProject(node, website) 4.9ms Passed
🟩 InstallWorkspaceDeps(node:~22) 57.4s Passed
🟦 RunTask(types:build) 1.8s Cached
🟦 RunTask(runtime:build) 783.5ms Cached
🟦 RunTask(website:typecheck) 269.3ms Cached
🟦 RunTask(website:lint) 310.4ms Cached
🟦 RunTask(website:test) 481.1ms Cached
🟩 RunTask(website:format) 10.1s Passed
🟦 RunTask(website:build) 16.7s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 22
Touched files
CHANGELOG.md
Cargo.lock
Cargo.toml
crates/app/Cargo.toml
crates/app/src/app.rs
crates/app/src/app_error.rs
crates/app/src/session.rs
crates/app/src/systems/analyze.rs
crates/cli/tests/snapshots/task_test__can_show_internal.snap
crates/cli/tests/snapshots/task_test__shows_inputs.snap
crates/cli/tests/snapshots/task_test__shows_outputs.snap
crates/common/src/helpers.rs
crates/common/src/lib.rs
crates/config/src/config_finder.rs
crates/config/src/config_loader.rs
crates/config/src/inherited_tasks_config.rs
crates/config/tests/inherited_tasks_config_test.rs
crates/config/tests/project_config_test.rs
crates/config/tests/template_config_test.rs
crates/config/tests/toolchain_config_test.rs
crates/config/tests/workspace_config_test.rs
crates/project-graph/tests/project_graph_test.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/tasks_builder_test.rs
justfile
website/blog/2024-10-07_moon-v1.29.mdx
website/docs/config/project.mdx
website/docs/config/tasks.mdx
website/docs/config/template.mdx
website/docs/config/toolchain.mdx
website/docs/config/workspace.mdx
website/docs/guides/pkl-config.mdx
website/sidebars.ts

Copy link

Run report for d8d7511c (windows-latest, 20)

Total time: 2m 6s | Comparison time: 5m 39s | Estimated savings: 3m 32s (62.7% faster)

Action Time Status Info
🟩 SyncWorkspace 345.1ms Passed
🟩 SetupToolchain(node:~20) 31.9s Passed
🟩 SyncProject(node, types) 6.6ms Passed
🟩 SyncProject(node, runtime) 5ms Passed
🟩 SyncProject(node, website) 5.8ms Passed
🟩 InstallWorkspaceDeps(node:~20) 1m 8s Passed
🟦 RunTask(types:build) 2.4s Cached
🟦 RunTask(runtime:build) 820.1ms Cached
🟦 RunTask(website:typecheck) 269.7ms Cached
🟦 RunTask(website:test) 384.5ms Cached
🟦 RunTask(website:lint) 396.2ms Cached
🟩 RunTask(website:format) 10.4s Passed
🟦 RunTask(website:build) 22.9s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
CHANGELOG.md
Cargo.lock
Cargo.toml
crates/app/Cargo.toml
crates/app/src/app.rs
crates/app/src/app_error.rs
crates/app/src/session.rs
crates/app/src/systems/analyze.rs
crates/cli/tests/snapshots/task_test__can_show_internal.snap
crates/cli/tests/snapshots/task_test__shows_inputs.snap
crates/cli/tests/snapshots/task_test__shows_outputs.snap
crates/common/src/helpers.rs
crates/common/src/lib.rs
crates/config/src/config_finder.rs
crates/config/src/config_loader.rs
crates/config/src/inherited_tasks_config.rs
crates/config/tests/inherited_tasks_config_test.rs
crates/config/tests/project_config_test.rs
crates/config/tests/template_config_test.rs
crates/config/tests/toolchain_config_test.rs
crates/config/tests/workspace_config_test.rs
crates/project-graph/tests/project_graph_test.rs
crates/task-builder/src/tasks_builder.rs
crates/task-builder/tests/tasks_builder_test.rs
justfile
website/blog/2024-10-07_moon-v1.29.mdx
website/docs/config/project.mdx
website/docs/config/tasks.mdx
website/docs/config/template.mdx
website/docs/config/toolchain.mdx
website/docs/config/workspace.mdx
website/docs/guides/pkl-config.mdx
website/sidebars.ts

@milesj milesj merged commit 697a02d into develop-1.32 Jan 29, 2025
27 checks passed
@milesj milesj deleted the 1.32-pkl branch January 29, 2025 02:26
milesj added a commit that referenced this pull request Feb 2, 2025
* Remove restrictions.

* Fix tests.

* Add pkl docs.

* Update labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant