Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoke, moonriver): no longer monitor InvArch, Litmus HMRP channels #3070

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Dec 4, 2024

What does it do?

Removes the HMRP channel monitoring for InvArch, Litmus foreign chains.

Litmus has become a parathread an InvArch crowd-loan has ended. @albertov19 will close the channels.

@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Dec 4, 2024
@RomarQ RomarQ requested review from pLabarta and timbrinded December 4, 2024 08:59
@RomarQ RomarQ self-assigned this Dec 4, 2024
timbrinded
timbrinded previously approved these changes Dec 4, 2024
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 4, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2268 KB (no changes) ✅

Moonbeam runtime: 2248 KB (no changes) ✅

Moonriver runtime: 2252 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2268 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2248 KB (+252 KB compared to latest release) ⚠️

Moonriver runtime: 2252 KB (+260 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Coverage Report

@@                     Coverage Diff                     @@
##           master   rq/remove-foreign-chain      +/-   ##
===========================================================
+ Coverage   74.39%                    74.52%   +0.13%     
  Files         375                       375              
  Lines       95766                     95766              
===========================================================
+ Hits        71241                     71363     +122     
- Misses      24525                     24403     -122     
Files Changed Coverage
/client/rpc/dev/src/lib.rs 89.16% (+32.53%) 🔼
/client/rpc/finality/src/lib.rs 81.25% (+68.75%) 🔼
/client/rpc/txpool/src/lib.rs 65.38% (+11.53%) 🔼
/client/rpc-core/txpool/src/types/content.rs 70.37% (+70.37%) 🔼
/client/rpc-core/txpool/src/types/inspect.rs 92.31% (+3.85%) 🔼

Coverage generated Wed Dec 4 10:37:06 UTC 2024

@crystalin crystalin merged commit 4224936 into master Dec 5, 2024
42 checks passed
@crystalin crystalin deleted the rq/remove-foreign-chain branch December 5, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants