SELFDESTRUCT must reset contract account #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2256 KB (no changes) ✅ Moonbeam runtime: 2236 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2256 KB (+228 KB compared to latest release) Moonbeam runtime: 2236 KB (+240 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/fix-selfdestruct +/- ##
======================================================
Coverage 74.70% 74.70% 0.00%
Files 369 369
Lines 94308 94308
======================================================
- Hits 70446 70445 -1
+ Misses 23862 23863 +1
|
This reverts commit c12604a.
ahmadkaouk
reviewed
Dec 3, 2024
Co-authored-by: Ahmad Kaouk <[email protected]>
ahmadkaouk
approved these changes
Dec 3, 2024
crystalin
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a test to ensure that when a contract is created with
CREATE2andSelf Destructedin the same transaction, it can be created again.The behaviour of
SELFDESTRUCTwas changed in Cancun hard-fork, where it will recover all funds to the target but not delete the account, except when called in the same transaction as creation.References:
https://eips.ethereum.org/EIPS/eip-6780
TODO:
Self-destructed contract accounts are now reaped from pallet system to match with the current ethereum behaviour. Users can now deploy the same contract multiple times when using the following instructions: CREATE2 and SELFDESTRUCT. Important to note, we support the eip-6780 specification, where a contract can only be self-destructed when SELFDESTRUCT is called in the same transaction the contract was created.