Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Upgrade Revision #1070

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Block Upgrade Revision #1070

merged 4 commits into from
Jan 22, 2025

Conversation

themacexpert
Copy link
Contributor

Description

Noticed we were off by one block on a historical runtime upgrade.

Checklist

  • I have added a label to this PR 🏷️

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) B0 - Needs Review Pull request is ready for review labels Jan 10, 2025
eshaben
eshaben previously approved these changes Jan 14, 2025
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben
Copy link
Contributor

eshaben commented Jan 14, 2025

@themacexpert looks like there are just some merge conflicts here

builders/build/runtime-upgrades.md Outdated Show resolved Hide resolved
builders/build/runtime-upgrades.md Outdated Show resolved Hide resolved
@themacexpert themacexpert requested a review from eshaben January 17, 2025 18:40
dawnkelly09
dawnkelly09 previously approved these changes Jan 21, 2025
Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice catch, thank you!

@themacexpert
Copy link
Contributor Author

@dawnkelly09 Fixed merge conflicts

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 22, 2025
@eshaben eshaben merged commit ec728f3 into master Jan 22, 2025
1 check passed
@eshaben eshaben deleted the themacexpert/histVers branch January 22, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) B1 - Ready to be Merged Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants