Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ape Changes #1062

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Ape Changes #1062

merged 4 commits into from
Jan 22, 2025

Conversation

themacexpert
Copy link
Contributor

Description

Fixed PR of #1055

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert mentioned this pull request Jan 6, 2025
13 tasks
@themacexpert
Copy link
Contributor Author

@dawnkelly09 Incorporated your requested changes into this one

@themacexpert themacexpert added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Jan 6, 2025
@themacexpert themacexpert added the B0 - Needs Review Pull request is ready for review label Jan 10, 2025
@themacexpert themacexpert requested a review from eshaben January 14, 2025 17:58
Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't select this on the files tab but, the terminal element snippet embedded at line 282 also needs updated re: the 4 versus 5 thing. The smaller terminal output a few lines down needs fixed as well. Sorry I didn't catch these on the last round! Everything else is looking great!

update-to-5

@themacexpert
Copy link
Contributor Author

I can't select this on the files tab but, the terminal element snippet embedded at line 282 also needs updated re: the 4 versus 5 thing. The smaller terminal output a few lines down needs fixed as well. Sorry I didn't catch these on the last round! Everything else is looking great!

update-to-5

Thanks Dawn, fixed

Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@themacexpert themacexpert added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 21, 2025
@eshaben eshaben merged commit c678015 into master Jan 22, 2025
1 check passed
@eshaben eshaben deleted the themacexpert/ape2 branch January 22, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) B1 - Ready to be Merged Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants