Move unit test method Missing Docblock to new code

[andrewnicols]

Either:

• Yes, it should
• Yes, but let's use a different Sniff response so it can be filtered and/or ignored in phpcs.xml
• No, it should not

All are very easy to implement.

I've gone for the middle ground for now.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (6974134) to head (613266f).

❗ Current head 613266f differs from pull request most recent head 801e32a. Consider uploading reports for the commit 801e32a to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #127   +/-   ##
=========================================
  Coverage     97.81%   97.82%           
- Complexity      825      827    +2     
=========================================
  Files            36       36           
  Lines          2425     2432    +7     
=========================================
+ Hits           2372     2379    +7     
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stronk7]

Ho,

I'm not sure about this one... I don't think that we have required/suggested to document all the unit tests (functions) in the past (although I've not been able to find any reference in one - or the opposite - direction).

Uhm... impact out there can be certainly huge, if they were being skipped previously...

Not sure, not sure...

[andrewnicols]

Bah - I think I missed a line in the old version. The old coding style made my brain completely miss that line, and there really weren't any good tests for the old one.

So we didn't previously add the error for test_ methods.

Added a commit to this patchset to do match that behaviour.

[stronk7]

That looks perfect. I'll squash the 2 commits together, as far as they are highly coupled.