Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for MDL-80396 #849

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

roland04
Copy link
Collaborator

@roland04 roland04 commented Jan 3, 2024

No description provided.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4ff4b11
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65b11a1b093a940008920795
😎 Deploy Preview https://deploy-preview-849--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewnicols
Copy link
Member

Is this a dupe of #848?

Copy link
Contributor

github-actions bot commented Jan 3, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 58 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 58 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 68 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 67 🟠 87 🟢 92 🟢 100 🟢 100 Report

@roland04 roland04 force-pushed the devdocs-bootstrap-media branch 3 times, most recently from 0046c93 to 5bded13 Compare January 5, 2024 08:07
@andrewnicols andrewnicols marked this pull request as draft January 9, 2024 07:05
@andrewnicols
Copy link
Member

Converting to draft to prevent accidental merge as the linked issues are not ready

@roland04 roland04 changed the title Devdocs bootstrap media Documentation for MDL-80396 Jan 9, 2024
@roland04 roland04 marked this pull request as ready for review January 23, 2024 10:07
@roland04 roland04 added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 23, 2024
@roland04 roland04 force-pushed the devdocs-bootstrap-media branch from 5bded13 to d6fe614 Compare January 24, 2024 09:26
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roland04!
Thanks for working on this issue and preparing this useful documentation that will help developers to migrate their CSS code!
The patch looks good and, as you'll see, I have only a minor suggestion (that you can ignore if you don't agree) :-)

docs/devupdate.md Outdated Show resolved Hide resolved
@roland04 roland04 force-pushed the devdocs-bootstrap-media branch from d6fe614 to 4ff4b11 Compare January 24, 2024 14:09
@roland04 roland04 requested a review from sarjona January 24, 2024 14:18
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving the devdocs. I'm happy to approve this patch (and I'll merge after rolling the weekly).

@sarjona sarjona added this pull request to the merge queue Jan 25, 2024
@sarjona sarjona removed the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 25, 2024
Merged via the queue into moodle:main with commit e5732ca Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants