Move to Docusaurus v3.x #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Note: I haven't got the jest tests working yet. I'm going to defer that to another issue because it's not critical. It's just testing one set of remark features. |
andrewnicols
force-pushed
the
docusaurusv3
branch
3 times, most recently
from
02ccc24 to
6ffbb2c
Compare
⚡️ Lighthouse report for the deploy preview of this PR
|
andrewnicols
force-pushed
the
docusaurusv3
branch
from
f92a189 to
22a8aa7
Compare
sarjona
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
@andrewnicols , thanks for working on this. I love the way you organised the commits because it was easy to understand and follow them. Well done!
The changes look great and it is amazing we can upgrade to docusaurus 3! Good job!! <3
I'm super-happy to approve this!
|
@andrewnicols although the patch is ready, I was wondering whether we should warn developers about this upgrade (because dependencies like Node will change). |
With mdx2 data may only be defined with `import`, or `export`. See https://mdxjs.com/docs/troubleshooting-mdx/#could-not-parse-expression-with-acorn-unexpected-content-after-expression for further information.
We should use backticks and not curly braces for descriptors in markdown. We do not support the markdown terms feature, which is not even a feature of extended markdown.
When any JSX is used (import/export), it must be followed by at least one empty line before and MDX is used, whether that is Markdown, or a React component. https://mdxjs.com/docs/troubleshooting-mdx/#could-not-parse-importexports-with-acorn-error
mdx2 is stricter and will fail on a number of sillier things which mdx2 was more liberal with: - Use of `<` - used to open JSX tags https://docusaurus.io/blog/preparing-your-site-for-docusaurus-v3#bad-usage-of--1 - Use of `{` - used to open JS expressions in JSX https://docusaurus.io/blog/preparing-your-site-for-docusaurus-v3#bad-usage-of-
andrewnicols
force-pushed
the
docusaurusv3
branch
from
22a8aa7 to
71d1de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits to allow us to migrate to Docusaurus 3.x