Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add SCSS deprecation page #814

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[docs] Add SCSS deprecation page #814

merged 2 commits into from
Nov 17, 2023

Conversation

roland04
Copy link
Collaborator

@roland04 roland04 commented Nov 16, 2023 •
edited
Loading

  • Convert the current "Deprecation" page into a subsection, moving deprecation.md to /deprecation/index.md
  • Add a new "SCSS deprecation" page under this new "Deprecation" subsection

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a256a03
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/655752ec561f520008f76b25
😎 Deploy Preview https://deploy-preview-814--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roland04 roland04 force-pushed the scss-deprecation branch 3 times, most recently from 48e9518 to b22f679 Compare November 16, 2023 16:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 92 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 60 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 67 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 64 🟠 87 🟢 92 🟢 100 🟢 100 Report

sarjona
sarjona requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @roland04!
Thanks for working on this page. You've done a great job with the SCSS deprecation process!
However, IMHO, it currently defines the immediate action but it doesn't explain when the styles defined in this deprecated.scss file will be removed.

@roland04 roland04 force-pushed the scss-deprecation branch 6 times, most recently from b6888e8 to 6c8bb77 Compare November 17, 2023 11:19
@roland04 roland04 requested a review from sarjona November 17, 2023 11:34
@roland04
Copy link
Collaborator Author

Thanks a lot for the review @sarjona!
I addressed the proposed changes and also added a new section about final deprecation.
Thank you!

sarjona
sarjona approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Mikel! These changes look amazing!! I love the new page! Good job!

@sarjona sarjona added this pull request to the merge queue Nov 17, 2023
Merged via the queue into moodle:main with commit 6b529d2 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarjona sarjona sarjona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roland04 @sarjona