Fixed pre-signed urls for regions like af-south-1 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxc-dev
approved these changes
Mar 19, 2024
…e-bucket-of-saas-hosted-bucket
mrostan
deleted the
mrostan/kil-3391-validator-failure-on-storage-bucket-of-saas-hosted-bucket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For regions created after 3-20-2019 (like
af-south-1) you need to use the regional endpoint when generating pre-signed URLs, if not the url is invalid and it fails with a400error like:One of the available fixes (for more information: boto/boto3#3015) is to create a second client with the regional URL and use it to generate the pre-signed URL.