Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blueprint backwards compatibility #1858

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 1 addition & 40 deletions core/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,18 +220,10 @@ valuePropertyDescriptor.value = function specialize(prototypeProperties, constru
Montage.defineProperty(constructor, "objectDescriptor", prototypeProperties.objectDescriptor);
}

if ("blueprint" in prototypeProperties) {
Montage.defineProperty(constructor, "blueprint", prototypeProperties.blueprint);
}

if ("objectDescriptorModuleId" in prototypeProperties) {
Montage.defineProperty(constructor, "objectDescriptorModuleId", prototypeProperties.objectDescriptorModuleId);
}

if ("blueprintModuleId" in prototypeProperties) {
Montage.defineProperty(constructor, "blueprintModuleId", prototypeProperties.blueprintModuleId);
}

Montage.defineProperties(prototype, prototypeProperties, true);

// needs to be done afterwards so that it overrides any prototype properties
Expand Down Expand Up @@ -1638,40 +1630,14 @@ exports._objectDescriptorModuleIdDescriptor = {
}
};

/***
* @deprecated use exports._objectDescriptorModuleIdDescriptor
*/
exports._blueprintModuleIdDescriptor = {
serializable:false,
enumerable: false,
get:function () {
var info = Montage.getInfoForObject(this);
var self = (info && !info.isInstance) ? this : this.constructor;
if ((!Object.getOwnPropertyDescriptor(self, "_objectDescriptorModuleId")) || (!self._objectDescriptorModuleId)) {
info = Montage.getInfoForObject(self);
var moduleId = info.moduleId,
slashIndex = moduleId.lastIndexOf("/"),
dotIndex = moduleId.lastIndexOf(".");
slashIndex = ( slashIndex === -1 ? 0 : slashIndex + 1 );
dotIndex = ( dotIndex === -1 ? moduleId.length : dotIndex );
dotIndex = ( dotIndex < slashIndex ? moduleId.length : dotIndex );
Montage.defineProperty(self, "_objectDescriptorModuleId", {
enumerable: false,
value: moduleId.slice(0, dotIndex) + ".meta"
});
}
return self._objectDescriptorModuleId;
}
};

exports._objectDescriptorDescriptor = {
serializable:false,
enumerable: false,
get:function () {
var info = Montage.getInfoForObject(this);
var self = info && !info.isInstance ? this : this.constructor;
if (!Object.getOwnPropertyDescriptor(self, "_objectDescriptor") || !self._objectDescriptor) {
var objectDescriptorModuleId = self.objectDescriptorModuleId || self.blueprintModuleId;
var objectDescriptorModuleId = self.objectDescriptorModuleId;
if (!objectDescriptorModuleId) {
throw new TypeError("ObjectDescriptor moduleId undefined for the module '" + JSON.stringify(self) + "'");
}
Expand Down Expand Up @@ -1720,11 +1686,6 @@ exports._objectDescriptorDescriptor = {
}
};

/**
* @deprecated use exports._objectDescriptorDescriptor
*/
exports._blueprintDescriptor = exports._objectDescriptorDescriptor;

// has to come last since serializer and deserializer depend on logger, which
// in turn depends on montage running to completion
require("./serialization/bindings");
4 changes: 2 additions & 2 deletions core/event/action-event-listener.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ var ActionEventListener = exports.ActionEventListener = Montage.specialize( /**
}

}, {
blueprintModuleId: require("../core")._blueprintModuleIdDescriptor,
blueprint: require("../core")._blueprintDescriptor
objectDescriptorModuleId: require("../core")._objectDescriptorModuleIdDescriptor,
objectDescriptor: require("../core")._objectDescriptorDescriptor
});

14 changes: 7 additions & 7 deletions core/event/action-event-listener.meta
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
{
"actionEventListener_handler": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "handler",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "object"
}
},
"actionEventListener_action": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "action",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "string"
}
},
"root": {
"prototype": "core/meta/module-blueprint",
"prototype": "core/meta/module-descriptor",
"values": {
"name": "ActionEventListener",
"customPrototype": false,
Expand All @@ -32,7 +32,7 @@
"@": "actionEventListener_action"
}
],
"propertyBlueprintGroups": {
"propertyDescriptorGroups": {
"actionEventListener": [
{
"@": "actionEventListener_handler"
Expand All @@ -42,7 +42,7 @@
}
]
},
"blueprintModule": {
"objectDescriptorModule": {
"%": "core/event/action-event-listener.meta"
},
"exportName": "ActionEventListener",
Expand Down
4 changes: 2 additions & 2 deletions core/media-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -617,8 +617,8 @@ var MediaController = exports.MediaController = Target.specialize(/** @lends Med

}, {

blueprintModuleId:require("./core")._blueprintModuleIdDescriptor,
objectDescriptorModuleId:require("./core")._objectDescriptorModuleIdDescriptor,

blueprint:require("./core")._blueprintDescriptor
objectDescriptor:require("./core")._objectDescriptorDescriptor

});
56 changes: 28 additions & 28 deletions core/media-controller.meta
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"mediaController_status": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "status",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -12,10 +12,10 @@
},

"mediaController_STOPPED": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "STOPPED",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -24,10 +24,10 @@
},

"mediaController_PLAYING": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "PLAYING",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -36,10 +36,10 @@
},

"mediaController_PAUSED": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "PAUSED",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -48,10 +48,10 @@
},

"mediaController_EMPTY": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "EMPTY",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -60,10 +60,10 @@
},

"mediaController_mediaController": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "mediaController",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "object",
Expand All @@ -72,10 +72,10 @@
},

"mediaController_position": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "position",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -84,10 +84,10 @@
},

"mediaController_duration": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "duration",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -96,10 +96,10 @@
},

"mediaController_autoplay": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "autoplay",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "boolean",
Expand All @@ -108,10 +108,10 @@
},

"mediaController_playbackRate": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "playbackRate",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -120,10 +120,10 @@
},

"mediaController_currentTime": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "currentTime",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -132,10 +132,10 @@
},

"mediaController_volume": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "volume",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "number",
Expand All @@ -144,10 +144,10 @@
},

"mediaController_mute": {
"prototype": "core/meta/property-blueprint",
"prototype": "core/meta/property-descriptor",
"values": {
"name": "mute",
"blueprint": {
"objectDescriptor": {
"@": "root"
},
"valueType": "boolean",
Expand All @@ -156,14 +156,14 @@
},

"root": {
"prototype": "core/meta/module-blueprint",
"prototype": "core/meta/module-object-descriptor",
"values": {
"name": "MediaController",
"exportName": "MediaController",
"module": {
"%": "core/media-controller"
},
"blueprintModule": {
"objectDescriptorModule": {
"%": "core/media-controller.meta"
},
"prototypeName": "MediaController",
Expand Down
1 change: 0 additions & 1 deletion core/meta/association-blueprint.js

This file was deleted.

49 changes: 0 additions & 49 deletions core/meta/association-blueprint.meta

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/binder-manager.js

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/binder-reference.js

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/binder-reference.meta

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/binder.js

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/binder.meta

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/blueprint-reference.js

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/blueprint-reference.meta

This file was deleted.

1 change: 0 additions & 1 deletion core/meta/blueprint.js

This file was deleted.

Loading