Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum size for end path icon #29

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

RailKill
Copy link
Collaborator

Super simple, one-line fix for #14. Bug was caused by size.y = 0 in MonologueGraphNode _common_update() which is supposed to shrink y content, but the end path node icon does not have a minimum size, so it shrinks to 0. The fix is to set a minimum size, that's it.

Copy link

sourcery-ai bot commented Aug 24, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RailKill - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@RailKill RailKill requested a review from atomic-junky August 24, 2024 21:53
Copy link
Collaborator

@atomic-junky atomic-junky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@atomic-junky atomic-junky merged commit 95c614e into main Aug 24, 2024
2 checks passed
@atomic-junky atomic-junky deleted the bugfix/flat-endpath branch August 24, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants