chore: Enables tests in CI for `mongodbatlas_privatelink_endpoint_service_data_federation_online_archive` resource #2001

lantoli · 2024-03-08T14:37:39Z

Description

Enables skipped tests in CI for mongodbatlas_privatelink_endpoint_service_data_federation_online_archive resource.

Works in dev and qa using the same project name
6 skipped tests enabled

Link to any related issue(s): CLOUDP-236603

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contribution guidelines
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

marcosuma · 2024-03-11T07:32:47Z

...nlinearchive/data_source_privatelink_endpoint_service_data_federation_online_archive_test.go

-	// Skip because private endpoints are deleted daily from dev environment
-	acc.SkipTestForCI(t)
+	var (
+		projectID               = acc.ProjectIDGlobal(t)


unrelated to this PR: are we planning to document and explain how to re-use the different level of projects?

at least i was planning to describe the list of shared projects and what they're used for, but yeah we can add more help about how to decide what level of reuse to do, let me think more about how to document that

marcosuma · 2024-03-11T07:33:57Z

internal/testutil/acc/name.go

+
+func projectID(tb testing.TB, name string) string {
+	tb.Helper()
+	SkipInUnitTest(tb)


curious: why we do this? should we also document it?

i've added more documentation to SkipInUnitTest, let me know if it helps

lantoli · 2024-03-11T07:54:58Z

internal/testutil/acc/skip.go

+// TF skipping test when TF_ACC=1 is not set is implemented inside resource.Test / ParallelTest functions.
+// SkipInUnitTest allows to call functions in the test body that must not run in unit test mode, only in acc/mig mode.
+// As an example it is used in ProjectIDGlobal so it can be called from the test methdod,
+// or in TestAccConfigDSAtlasUser_ByUserID so it can call fetchUser.


@marcosuma FYI

internal/testutil/acc/name.go

...ononlinearchive/resource_privatelink_endpoint_service_data_federation_online_archive_test.go

AgustinBettati · 2024-03-11T09:08:53Z

.github/workflows/acceptance-tests.yml

+      mongodb_atlas_private_endpoint_id: ${{ secrets.MONGODB_ATLAS_PRIVATE_ENDPOINT_ID }}
+      mongodb_atlas_private_endpoint_dns_name: ${{ secrets.MONGODB_ATLAS_PRIVATE_ENDPOINT_DNS_NAME }}


in the case of QA are the endpoint_id and endpoint_dns_name the same value?

yes, i checked and it worked, they are AWS values.

in fact that's why any project can be used for these tests, not special config needed

internal/testutil/acc/skip.go

Co-authored-by: Agustin Bettati <[email protected]>

EspenAlbert

LGTM.
One question, how is the test-acc-tf-p-keep-global project created in dev/qa?

lantoli · 2024-03-11T09:38:15Z

@EspenAlbert i created test-acc-tf-p-keep-global manually as it won't be deleted, i'll document all common projects and what config they need. this particular project doesn't need any extra config, just to be created with that name

lantoli added 10 commits March 8, 2024 15:14

fix prechecks to fail if not met

ed6524c

skip gov test

eaf6294

enable basic test

ecb2e9e

refactor PreCheckPrivateEndpoint

a8af35d

move vars inside the tests

5f4ea86

ProjectIDPrivateEndpoint

32a377c

config vars in CI

bd7d104

fail if project id is not found

9a11fba

use global project

e78b287

don't run project id in uni tests

ba2dc7d

lantoli marked this pull request as ready for review March 11, 2024 06:49

lantoli requested a review from a team as a code owner March 11, 2024 06:49

marcosuma reviewed Mar 11, 2024

View reviewed changes

marcosuma approved these changes Mar 11, 2024

View reviewed changes

comment SkipInUnitTest

e58f25c

lantoli commented Mar 11, 2024

View reviewed changes

oarbusi approved these changes Mar 11, 2024

View reviewed changes

EspenAlbert reviewed Mar 11, 2024

View reviewed changes

internal/testutil/acc/name.go Show resolved Hide resolved

EspenAlbert reviewed Mar 11, 2024

View reviewed changes

...ononlinearchive/resource_privatelink_endpoint_service_data_federation_online_archive_test.go Show resolved Hide resolved

AgustinBettati reviewed Mar 11, 2024

View reviewed changes

lantoli and others added 2 commits March 11, 2024 10:27

Update internal/testutil/acc/skip.go

bd125f6

Co-authored-by: Agustin Bettati <[email protected]>

error message when project name is not found

64bb5da

EspenAlbert approved these changes Mar 11, 2024

View reviewed changes

no need to use Sprintf

c9aa59a

lantoli merged commit 7f8a674 into master Mar 11, 2024
45 checks passed

lantoli deleted the CLOUDP-236603_privatelinkendpointservicedatafederationonlinearchive branch March 11, 2024 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Enables tests in CI for `mongodbatlas_privatelink_endpoint_service_data_federation_online_archive` resource #2001

chore: Enables tests in CI for `mongodbatlas_privatelink_endpoint_service_data_federation_online_archive` resource #2001

lantoli commented Mar 8, 2024 •

edited

Loading

marcosuma Mar 11, 2024

lantoli Mar 11, 2024

marcosuma Mar 11, 2024

lantoli Mar 11, 2024

lantoli Mar 11, 2024

AgustinBettati Mar 11, 2024

lantoli Mar 11, 2024

EspenAlbert left a comment

lantoli commented Mar 11, 2024

		mongodb_atlas_private_endpoint_id: ${{ secrets.MONGODB_ATLAS_PRIVATE_ENDPOINT_ID }}
		mongodb_atlas_private_endpoint_dns_name: ${{ secrets.MONGODB_ATLAS_PRIVATE_ENDPOINT_DNS_NAME }}

chore: Enables tests in CI for mongodbatlas_privatelink_endpoint_service_data_federation_online_archive resource #2001

chore: Enables tests in CI for mongodbatlas_privatelink_endpoint_service_data_federation_online_archive resource #2001

Conversation

lantoli commented Mar 8, 2024 • edited Loading

Description

Type of change:

Required Checklist:

Further comments

marcosuma Mar 11, 2024

Choose a reason for hiding this comment

lantoli Mar 11, 2024

Choose a reason for hiding this comment

marcosuma Mar 11, 2024

Choose a reason for hiding this comment

lantoli Mar 11, 2024

Choose a reason for hiding this comment

lantoli Mar 11, 2024

Choose a reason for hiding this comment

AgustinBettati Mar 11, 2024

Choose a reason for hiding this comment

lantoli Mar 11, 2024

Choose a reason for hiding this comment

EspenAlbert left a comment

Choose a reason for hiding this comment

lantoli commented Mar 11, 2024

chore: Enables tests in CI for `mongodbatlas_privatelink_endpoint_service_data_federation_online_archive` resource #2001

chore: Enables tests in CI for `mongodbatlas_privatelink_endpoint_service_data_federation_online_archive` resource #2001

lantoli commented Mar 8, 2024 •

edited

Loading