chore: Drop dependency on pointy #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
changed the title
gssbzn
changed the title
gssbzn
changed the title
lantoli
reviewed
Feb 16, 2024
| SampleSizeBIConnector: pointy.Int64(110), | ||
| TransactionLifetimeLimitSeconds: pointy.Int64(300), | ||
| NoTableScan: conversion.Pointer(false), | ||
| OplogSizeMB: conversion.Pointer[int64](1000), |
There was a problem hiding this comment.
does it fail if [int64] is not specified?
There was a problem hiding this comment.
yes, OplogSizeMB is int64 and the literal 1000 is int so you need to provide the cast
lantoli
reviewed
Feb 16, 2024
| CopyProtectionEnabled: conversion.Pointer(d.Get("copy_protection_enabled").(bool)), | ||
| EncryptionAtRestEnabled: conversion.Pointer(d.Get("encryption_at_rest_enabled").(bool)), | ||
| PitEnabled: conversion.Pointer(d.Get("pit_enabled").(bool)), | ||
| RestoreWindowDays: conversion.Pointer(cast.ToInt(d.Get("restore_window_days"))), |
There was a problem hiding this comment.
not sure why it's not similar to other places, e.g. d.Get("restore_window_days").(int)
There was a problem hiding this comment.
🤷 I'm just replacing the pointer, there seem sto be a combination of using cast and .int all over
lantoli
reviewed
Feb 16, 2024
| ProtoV6ProviderFactories: acc.TestAccProviderV6Factories, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccMongoDBAtlasProjectsConfigWithDS(projectName, orgID, | ||
| []*admin.TeamRole{ | ||
| { | ||
| TeamId: conversion.StringPtr(acc.GetProjectTeamsIdsWithPos(0)), | ||
| TeamId: conversion.StringPtr(acc.GetProjectTeamsIDsWithPos(0)), |
There was a problem hiding this comment.
do you know why Ids didn't fail the linter before?
There was a problem hiding this comment.
I have a newer linter locally which picks these now, it was a small drive by I didn't bother in trying to switch to your version of the linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop dependency on pointy and use
conversion.Pointerinstead