Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrades cloud_backup_schedule resource to auto-generated SDK #1946

Merged
merged 23 commits into from
Feb 21, 2024
Merged

chore: Upgrades cloud_backup_schedule resource to auto-generated SDK #1946

merged 23 commits into from
Feb 21, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Feb 14, 2024 •
edited by lantoli
Loading

Description

Upgrades cloud_backup_schedule resource to auto-generated SDK.

Adds migration test.

Link to any related issue(s): CLOUDP-229747

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

oarbusi and others added 22 commits February 14, 2024 15:17
@oarbusi
initial refactor
72e5bc4
@oarbusi
upgrade to new auto-generated SDK
ee80815
@oarbusi
add migration test
43f8333
@oarbusi
use get
671de4d
@oarbusi
don't check values of attributes in mig test
9171044
@oarbusi
fix time conversion
c81552a
@oarbusi
fix time conversion in data soruce
d449a41
@oarbusi
don't set policyItem Id if empty
d4abec0
@oarbusi
roll back change for GetOkExists
5ceb7e4
@oarbusi
use hasChange
fc4b66e
@oarbusi
change to conversion.Pointer
02f6215
@oarbusi
use getOk
fd40985
@oarbusi
use getokexists
4da3b01
@oarbusi
only check error in check destroy
f53e197
@oarbusi
Merge branch 'master' into CLOUDP-229747
a3312f2
@lantoli
remove unneeded generic param
a7beb49
@lantoli
use GetClusterInfo
a0e459d
@lantoli
expandPolicyItem
708bf19
@lantoli
ExistingClusterUsed
839d5ba
@lantoli
Merge branch 'master' into CLOUDP-229747
2748c3a 
* master:
  chore: Bump dorny/paths-filter from 3.0.0 to 3.0.1 (#1964)
  chore: Bump github.com/aws/aws-sdk-go from 1.50.17 to 1.50.22 (#1965)
  chore: Upgrades `advanced_cluster` resource to auto-generated SDK (#1947)
  fix: mongodbatlas_encryption_at_rest resource with google_cloud_kms_config (#1962)
  chore: Restores atlas streams guide in examples section (#1958)
  chore: Signs created tag during release process (#1960)
@lantoli
TestStepCheckEmptyPlan and random name functions
406101f
@lantoli
GetClusterInfo for remaining tests
fc43963
@lantoli lantoli changed the title chore: Upgrades cloud_backup_schedule resource to auto-generated SDK chore: Upgrades cloud_backup_schedule resource to auto-generated SDK Feb 21, 2024
@lantoli lantoli marked this pull request as ready for review February 21, 2024 10:04
@lantoli lantoli requested a review from a team as a code owner February 21, 2024 10:04
@lantoli lantoli merged commit 5aa9dfd into master Feb 21, 2024
44 checks passed
@lantoli lantoli deleted the CLOUDP-229747 branch February 21, 2024 17:02
lantoli added a commit that referenced this pull request Feb 21, 2024
@lantoli
Merge branch 'master' into atlas-sdk-update
88b52e7 
* master:
  chore: Upgrades `cloud_backup_schedule` resource to auto-generated SDK (#1946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oarbusi @lantoli