Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades cloud_backup_snapshot resource to auto-generated SDK #1936

Merged
merged 12 commits into from
Feb 13, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Feb 12, 2024

Description

Upgrades cloud_backup_snapshot resource to auto-generated SDK.

  • Migration tests created.
  • Current tests were for replica set clusters, tests added for sharded clusters.
  • Add ability to use existing cluster and project in local tests.
  • Extracted unit tests to model file.

Link to any related issue(s): CLOUDP-226078

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli marked this pull request as ready for review February 13, 2024 14:11
@lantoli lantoli requested a review from a team as a code owner February 13, 2024 14:11
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit 900b1b0 into master Feb 13, 2024
45 checks passed
@lantoli lantoli deleted the CLOUDP-226078_cloud_backup_snapshot branch February 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants