chore: Upgrades private_link_endpoint resource to auto-generated SDK. #1901

marcosuma · 2024-02-01T14:56:59Z

Description

Upgrades private_link_endpoint resource to auto-generated SDK.

Migration tests created.

Link to any related issue(s): CLOUDP-227301

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contribution guidelines
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

internal/service/privatelinkendpoint/resource_privatelink_endpoint_migration_test.go

internal/service/privatelinkendpoint/resource_privatelink_endpoint_test.go

lantoli · 2024-02-02T05:59:44Z

internal/service/privatelinkendpoint/resource_privatelink_endpoint_migration_test.go

+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig"
+)
+
+func TestAccMigrationPrivateLinkEndpoint_basic(t *testing.T) {


it's not being run in CI

…oint_migration_test.go Co-authored-by: Leo Antoli <[email protected]>

internal/service/privatelinkendpoint/resource_privatelink_endpoint_test.go

lantoli

great job!

AgustinBettati

LGTM, one doubt

AgustinBettati · 2024-02-02T08:38:00Z

internal/service/privatelinkendpoint/resource_privatelink_endpoint.go

+		if _, ok := p.GetStatusOk(); ok {
+			status = p.GetStatus()
+		}


q: why was this if added? Can see the possibility of non Ok status resulting in a "" status while this was not the case before, so just making sure no change in behavior here.

should we return an error if the status is not ok?

@AgustinBettati this was added because of a fmt check error:

Formatting go files ==> Fixing linters errors... fieldalignment -json -fix ./... {} golangci-lint run --fix internal/service/privatelinkendpoint/resource_privatelink_endpoint.go:322:13: evalOrder: may want to evaluate p.GetStatus() before the return statement (gocritic) return p, p.GetStatus(), nil ^ make: *** [lint-fix] Error 1

should we return an error if the status is not ok?

I think returning "" should already be enough. even if you return an error (unless you mean completely failing the whole request) will end up in a retry of the request since this code is in the refreshFunc logic.

andreaangiolillo

LGTM

andreaangiolillo · 2024-02-02T09:39:49Z

internal/service/privatelinkendpoint/resource_privatelink_endpoint.go

+		if _, ok := p.GetStatusOk(); ok {
+			status = p.GetStatus()
+		}


should we return an error if the status is not ok?

internal/service/privatelinkendpoint/resource_privatelink_endpoint_migration_test.go

marcosuma added 2 commits February 1, 2024 15:55

chore: Upgrades private_link_endpoint resource to auto-generated SDK.

2f884e7

adds migration test.

7f05052

marcosuma marked this pull request as ready for review February 1, 2024 18:38

marcosuma requested a review from a team as a code owner February 1, 2024 18:38