Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes from env variable to input in Import GPG key #1898

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Feb 1, 2024

Description

Because of the bump of crazy-max/ghaction-import-gpg from 2.1.0 to 6.1.0, a breaking change has to be fixed for the github action to work. See https://github.com/crazy-max/ghaction-import-gpg for details on how to use it now

This was first changed to gpg-private-key in 3.0.0 https://github.com/crazy-max/ghaction-import-gpg/releases/tag/v3.0.0
Later changed to gpg_private_key in 4.0.0 https://github.com/crazy-max/ghaction-import-gpg/releases/tag/v4.0.0

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review February 1, 2024 09:45
@oarbusi oarbusi requested a review from a team as a code owner February 1, 2024 09:45
@oarbusi oarbusi changed the title fix: change from env variable to input in Import GPG key fix: Changes from env variable to input in Import GPG key Feb 1, 2024
@github-actions github-actions bot added the bug label Feb 1, 2024
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you adjust the PR title prefix from fix: to chore: and remove the bug label? This change is not a bug fix for terraform users but instead a fix which is internal to us, so making this adjustment will improve the generated changelog.

@oarbusi oarbusi removed the bug label Feb 1, 2024
@oarbusi oarbusi changed the title fix: Changes from env variable to input in Import GPG key chore: Changes from env variable to input in Import GPG key Feb 1, 2024
@github-actions github-actions bot added bug and removed bug labels Feb 1, 2024
@oarbusi oarbusi merged commit 4198bc7 into master Feb 1, 2024
45 of 48 checks passed
@oarbusi oarbusi deleted the fix-gpg_private_key branch February 1, 2024 10:03
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants