chore: Upgrades access_list_api_key resource to auto-generated SDK #1877
Conversation
internal/service/accesslistapikey/data_source_accesslist_api_keys.go
Outdated
Show resolved
Hide resolved
| "github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig" | ||
| ) | ||
|
|
||
| func TestAccMigrationProjectAccesslistAPIKey_SettingIPAddress(t *testing.T) { |
| accessListAPIKeys, _, err := conn.AccessListAPIKeys.List(ctx, orgID, apiKeyID, options) | ||
| params := &admin.ListApiKeyAccessListsEntriesApiParams{ | ||
| PageNum: pointy.Int(d.Get("page_num").(int)), | ||
| ItemsPerPage: pointy.Int(d.Get("items_per_page").(int)), |
There was a problem hiding this comment.
Since this now defines a pointer to the int value of the attribute, would there be a risk we send items per page to 0 if this attribute is not defined?
There was a problem hiding this comment.
if the attribute is not sent, the API should apply the default value (0) anyway
There was a problem hiding this comment.
Just to clarify the risk is in ItemsPerPage which has a default value of 100, if a pointer value to 0 is defined the response will return 0 items when the attribute is not defined.
There was a problem hiding this comment.
ah thanks 👍 , I thought we were talking about page_num
There was a problem hiding this comment.
it was working with items_per_page = 0, i suppose the server was assuming the default value. anyway it's fixed now to send nil (so not sent to server) if values are 0
|
|
||
| _, resp, err := conn.AccessListAPIKeys.Create(ctx, orgID, apiKeyID, createRequest) | ||
| _, resp, err := connV2.ProgrammaticAPIKeysApi.CreateApiKeyAccessList(context.Background(), orgID, apiKeyID, accessList).Execute() |
There was a problem hiding this comment.
Fortunately this is not CFN :)
| _, resp, err := connV2.ProgrammaticAPIKeysApi.CreateApiKeyAccessList(context.Background(), orgID, apiKeyID, accessList).Execute() | |
| _, resp, err := connV2.ProgrammaticAPIKeysApi.CreateApiKeyAccessList(ctx, orgID, apiKeyID, accessList).Execute() |
There was a problem hiding this comment.
thx, i missed that one 😅
|
|
||
| accessListAPIKeys, _, err := conn.AccessListAPIKeys.List(ctx, orgID, apiKeyID, options) | ||
| params := &admin.ListApiKeyAccessListsEntriesApiParams{ | ||
| PageNum: conversion.IntPtr(d.Get("page_num").(int)), |
There was a problem hiding this comment.
@AgustinBettati this sends nil if int is 0, as we want here
Description
Upgrades access_list_api_key resource to auto-generated SDK.
Migration tests created.
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-226074
Type of change:
Required Checklist:
Further comments