Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase parallelism in Test Suite #1859

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Jan 19, 2024

Description

Increases parallelism in Test Suite to make test execution faster.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli marked this pull request as ready for review January 19, 2024 13:23
@lantoli lantoli requested a review from a team as a code owner January 19, 2024 13:23
@lantoli lantoli requested a review from oarbusi January 19, 2024 15:50
@maastha
Copy link
Collaborator

maastha commented Jan 19, 2024

[q] just for my knowledge, how do we test this?

@lantoli
Copy link
Member Author

lantoli commented Jan 19, 2024

@maastha I ran manually the Test Suite GH action in this branch. for this change, i didn't expect until the end, i saw that both tests were running in parallel and seemed right and canceled. for more complex changes i wait until the GH action in this branch finishes completely

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only risk I see is that organization reaches limit of projects but we can always revert and look into other options in that case.

@lantoli
Copy link
Member Author

lantoli commented Jan 19, 2024

@AgustinBettati it could happen but i guess it'll fail because other things. so to go a bit more smoother I'm going to have mig and acc tests in paralel, but each on in serial and see what happens. if it works we can increase parallelism inside acc and mig tests

@lantoli lantoli force-pushed the test_suite_parallel branch from de89eda to 1597270 Compare January 19, 2024 18:07
@lantoli lantoli merged commit 386d32a into master Jan 19, 2024
@lantoli lantoli deleted the test_suite_parallel branch January 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants