-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add templates for mongodbatlas_search_deployment #1816
Conversation
@@ -0,0 +1,26 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we follow the convention of placing templates within ./templates
folder? reference: https://github.com/hashicorp/terraform-plugin-docs?tab=readme-ov-file#conventional-paths.
For this example it would mean placing the file in ./templates/resources/search_deployment.html.markdown.tmpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion here. Updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
docs/templates/data-sources/search_deployment.html.markdown.tmpl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would just remove the CLOUDP-* reference from the PR title out of convention
Description
Ticket: CLOUDP-221361
This PR adds the templates needed to generate the documentation for the
mongodbatlas_search_deployment
resource and data source via TFplugindocs. See Spec: Add HashiCorp automation tooling to Terraform development process for more info.Link to any related issue(s):
Type of change:
Required Checklist:
Further comments