chore: Adjusts release process to run tests against QA before releasing

[AgustinBettati]

Description

Link to any related issue(s): CLOUDP-220682

Used a forked repository to test logic of when acceptances test and release is run.

Scenarios that were tested:

• When providing an invalid input (1.0.0): execution of tests and release is skipped
• When doing a release (v1.0.0) or a pre release (v1.0.0-pre):
  • with skip value true -> tests are not run and release is made
  • with skip value empty -> tests are run
    • if test fails release job is not run
    • if test are successful release job runs

What has not been tested and will be tested on release?

• During testing in the forked repository execution of acceptance tests was replaced with a dummy job, so the call to the acceptance test workflow it not tested (was copied from working definition in test-suite.yml#L63.

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contribution guidelines
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

[AgustinBettati]

as of now tag is not being signed, which is the behaviour we currently have when creating tags for our releases. Will reach out to security team to verify if we can use the gpg signing feature of this action.

[andreaangiolillo]

Could you confirm that the action is creating an annotated tag?

[AgustinBettati]

yes verified that annotated tags were created in the forked repo used for testing, can also be seen in the code https://github.com/rickstaa/action-create-tag/blob/main/entrypoint.sh#L79

[andreaangiolillo]

LGTM. Thanks for all the follow ups