Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: DOCSP-34594 clarify use case for deleting network containers #1811

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

kanchana-mongodb
Copy link
Contributor

@kanchana-mongodb kanchana-mongodb commented Jan 4, 2024

Description

The documentation for deleting network containers could use a bit more clarification around when/whether it should be used. The intent is for customer to use this for setting up VPC peering in their project before creating any clusters. However, once clusters have been created in the project, the ability to delete the network container is effectively lost. Either the container can't be deleted because the clusters exist, or it can't be deleted because there are orphaned cloud provider entities left around in the container after deleting a cluster, which are cleaned up asynchronously along with the container itself.

Link to any related issue(s): DOCSP-34594

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@kanchana-mongodb kanchana-mongodb requested a review from a team as a code owner January 4, 2024 17:31
Copy link
Contributor

@zach-carr zach-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosuma marcosuma changed the title DOCSP-34594 clarify use case for deleting network containers doc: DOCSP-34594 clarify use case for deleting network containers Jan 5, 2024
@zach-carr zach-carr merged commit bfc40ae into mongodb:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants