chore: Enable Network peering acc tests using AWS to run as part of CI #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,38 +83,37 @@ func TestAccMigrationProjectDSProjectIPAccessList_SettingCIDRBlock(t *testing.T) | |||
| } | |||
|
|
|||
| func TestAccMigrationProjectDSProjectIPAccessList_SettingAWSSecurityGroup(t *testing.T) { | |||
| acc.SkipTestExtCred(t) | |||
| projectName := acctest.RandomWithPrefix("test-acc-migration-project-aws") | |||
There was a problem hiding this comment.
Follow up changes of #1784 where I forgot to update the migration and data source tests
AgustinBettati
approved these changes
Dec 27, 2023
internal/service/networkpeering/resource_network_peering_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Agustin Bettati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: https://jira.mongodb.org/browse/CLOUDP-219839
This PR enables the network peering acc tests using AWS to run as part of our CI pipeline. It also updates the project ip access-list tests that were missed in #1784 to run in the CI pipeline
Link to any related issue(s):
Type of change:
Required Checklist:
Testing
I run the test locally
Running tool: /Users/andrea.angiolillo/.asdf/shims/go test -timeout 300000s -run ^TestAccNetworkRSNetworkPeering_basicAWS$ github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering
ok github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering 177.808s
I run the tests as part of the CI pipeline