Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CLOUDP-214958: Run acc tests faster in local reusing cluster database_user #1775

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Dec 19, 2023

Description

Ticket: CLOUDP-214958

This PR adds the option to use a personal cluster to run the acceptance tests locally

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

Testing

Tested locally

With my cluster

Running tool: /Users/andrea.angiolillo/.asdf/shims/go test -timeout 300000s -run ^TestAccConfigRSDatabaseUser_withScopes$ github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser

ok  	github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser	12.494s

Without cluster

2023-12-19T15:38:03.474Z [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccConfigRSDatabaseUser_withScopesAndEmpty
PASS

@mongodb mongodb deleted a comment from github-actions bot Dec 19, 2023
@mongodb mongodb deleted a comment from github-actions bot Dec 19, 2023
@mongodb mongodb deleted a comment from github-actions bot Dec 19, 2023
@andreaangiolillo andreaangiolillo marked this pull request as ready for review December 19, 2023 20:36
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner December 19, 2023 20:36
@andreaangiolillo andreaangiolillo merged commit 97e74ba into master Dec 20, 2023
@andreaangiolillo andreaangiolillo deleted the CLOUDP-214958 branch December 20, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants