fix: Doesn't disable X.509 in the project when mongodbatlas_x509_authentication_database_user resource is deleted #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosuma
reviewed
Dec 15, 2023
| } | ||
| } | ||
|
|
||
| // We don't do anything because X.509 certificates can not be deleted or disassociated from a user |
There was a problem hiding this comment.
Is this a breaking change? Do we want to hold it on after we release 1.14.0?
There was a problem hiding this comment.
I guess it's not a breaking change because it'd return error now...
There was a problem hiding this comment.
no, on the contrary, the client wants this as soon as possible. The behavior will change, but for the better, because current behavior is unexpected
There was a problem hiding this comment.
I understand we are limited in what we can for this scenario, but just want to make sure there are no significant side effects.
From what I understand if a user now deletes the mongodbatlas_x509_authentication_database_user the "Self-Managed X.509 Authentication" setting would still be enabled, and the users would have to disable manually if that is his intention.
There was a problem hiding this comment.
correct. but the normal use case is to have multiple users, so when you disable one you don't want to disable others.
As an example in Atlas UI when you delete the database user, X.509 project config keeps enabled. Here we're doing the same behavior as in the UI.
There was a problem hiding this comment.
there is useful info in the comments in: https://jira.mongodb.org/browse/HELP-53363
marcosuma
reviewed
Dec 18, 2023
| @@ -17,6 +17,8 @@ description: |- | |||
|
|
|||
| -> **NOTE:** Groups and projects are synonymous terms. You may find group_id in the official documentation. | |||
|
|
|||
| -> **NOTE:** Before provider version 1.14.0, Self-managed X.509 Authentication was disabled for the project when this resource was deleted. | |||
There was a problem hiding this comment.
This feels incomplete. Should we clarify that now we do nothing and why?
marcosuma
reviewed
Dec 18, 2023
| } | ||
| } | ||
|
|
||
| // We don't do anything because X.509 certificates can not be deleted or disassociated from a user |
There was a problem hiding this comment.
maybe worth it to mention https://jira.mongodb.org/browse/HELP-53363 in the comment
marcosuma
reviewed
Dec 18, 2023
Comment on lines
20
to
21
| -> **NOTE:** Before provider version 1.14.0, Self-managed X.509 Authentication was disabled for the project when this resource was deleted. From that version on, it is not disabled because the other users may want to continue using X.509. | ||
|
|
There was a problem hiding this comment.
Suggested change
| -> **NOTE:** Before provider version 1.14.0, Self-managed X.509 Authentication was disabled for the project when this resource was deleted. From that version on, it is not disabled because the other users may want to continue using X.509. | |
| -> **NOTE:** Before provider version 1.14.0, Self-managed X.509 Authentication was disabled for the project when this resource was deleted. From that version on, it won't be disabled to let other users continue using X.509 within the same project. | |
@lantoli check if within the same project is correct please. If you are ok, accept the suggestion (just a minor word refactoring).
There was a problem hiding this comment.
thx, changing for a similar sentence
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doesn't disable X.509 in the project when mongodbatlas_x509_authentication_database_user resource is deleted
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-218316
Type of change:
Required Checklist:
Further comments