-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix mongodbatlas_clusters plural data source to set auto_scaling_disk_gb_enabled attribute correctly #1722
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -375,7 +375,7 @@ func flattenClusters(ctx context.Context, d *schema.ResourceData, conn *matlas.C | |||
"advanced_configuration": advancedcluster.FlattenProcessArgs(processArgs), | |||
"auto_scaling_compute_enabled": clusters[i].AutoScaling.Compute.Enabled, | |||
"auto_scaling_compute_scale_down_enabled": clusters[i].AutoScaling.Compute.ScaleDownEnabled, | |||
"auto_scaling_disk_gb_enabled": clusters[i].BackupEnabled, | |||
"auto_scaling_disk_gb_enabled": clusters[i].AutoScaling.DiskGBEnabled, | |||
"backup_enabled": clusters[i].BackupEnabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change/add some tests that fail before this change and pass after?
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
bump |
Description
This PR fixes auto_scaling_disk_gb_enabled to be set correctly in the plural mongodbatlas_clusters data source for all results. Currently this is being set to BackupEnabled attribute from the API response.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments