chore: Uses official CLI GH action in TF clean-up workflow

[lantoli]

Description

Uses official CLI GH action in TF clean-up workflow.

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-215921

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contribution guidelines
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

[andreaangiolillo]

Suggested change

	- uses: mongodb/atlas-github-action@main
	- uses: mongodb/atlas-github-action@v0.2.0

[lantoli]

@andreaangiolillo it's the recommended way in the instructions: https://github.com/marketplace/actions/atlas-cli-github-action

also I suppose being our GH action, it's not so a big (security) problem to use main.

@matt-condon WDYT is better to use here? (if v0.2.0 , should we change example / doc?

[andreaangiolillo]

Using master is a bad practice as we may push a bug unintentionally. I will update the description to be at least @latest (still not a best practice but at least an official release)

[andreaangiolillo]

mongodb/atlas-github-action#13

[lantoli]

@andreaangiolillo i see your point of master having a bug even if not published. keeping v0.2.0 at the moment as latest doesn't work.

[matt-condon]

using @v0 should also be an option if you always want the latest published version without breaking changes

Edit: for clarity, would need to publish a new version

[andreaangiolillo]

Why do you need this?

[lantoli]

i found it interesting in case something fails to compare with local atlas version

[lantoli]

but you're right we won't normally use it, removed

[andreaangiolillo]

LGTM

[github-actions]

Package	Line Rate	Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion	31%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/dsschema	100%	✔
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate	68%	➖
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration	33%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/apikey	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/auditing	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/backupcompliancepolicy	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupschedule	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportbucket	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportjob	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotrestorejob	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudprovideraccess	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clusteroutagesimulation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdbrole	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdnsconfigurationclusteraws	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/datalakepipeline	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/eventtrigger	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedquerylimit	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsidentityprovider	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/globalclusterconfig	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapconfiguration	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapverify	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/maintenancewindow	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkcontainer	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/onlinearchive	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/organization	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/orginvitation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privateendpointregionalmode	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpoint	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserverless	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservice	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserviceserverless	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectinvitation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/rolesorgid	7%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment	23%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchindex	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/serverlessinstance	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streaminstance	14%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/teams	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/thirdpartyintegration	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/x509authenticationdatabaseuser	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc	5%	❌
Summary	4% (453 / 10805)	❌