feat: Migrates some resources to new file structure #1705

lantoli · 2023-12-04T20:50:02Z

Description

Migrates some resources to new file structure:

global_cluster_config CLOUDP-214997
x509_authentication_database_user CLOUDP-214987
private_endpoint_regional_mode CLOUDP-214995
privatelink_endpoint_service_data_federation_online_archive CLOUDP-214999
privatelink_endpoint_service_serverless CLOUDP-214989
privatelink_endpoint_service CLOUDP-214986
privatelink_endpoint CLOUDP-214993
privatelink_endpoint_serverless CLOUDP-215019
third_party_integration CLOUDP-215011
online_archive CLOUDP-214984
custom_dns_configuration_cluster_aws CLOUDP-215013
ldap_configuration CLOUDP-214981
ldap_verify CLOUDP-214968
search_index CLOUDP-214976
data_lake_pipeline CLOUDP-215001
event_trigger CLOUDP-215021
project_invitation CLOUDP-214985
org_invitation CLOUDP-214971
organization CLOUDP-215007
serverless_instance CLOUDP-214975
cluster_outage_simulation CLOUDP-214966
shared_tier_restore_job (only data sources)
roles_org_id (only data sources)

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contribution guidelines
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

…link_endpoint_service_serverless

github-actions · 2023-12-05T05:54:41Z

Package	Line Rate	Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion	31%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate	68%	➖
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration	33%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/apikey	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/auditing	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/backupcompliancepolicy	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupschedule	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportbucket	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportjob	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotrestorejob	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudprovideraccess	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clusteroutagesimulation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdbrole	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdnsconfigurationclusteraws	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/datalakepipeline	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/eventtrigger	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedquerylimit	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsidentityprovider	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/globalclusterconfig	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapconfiguration	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapverify	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/maintenancewindow	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkcontainer	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/onlinearchive	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/organization	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/orginvitation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privateendpointregionalmode	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpoint	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserverless	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservice	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserviceserverless	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectinvitation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/rolesorgid	7%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment	23%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchindex	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/serverlessinstance	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/teams	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/thirdpartyintegration	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/x509authenticationdatabaseuser	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc	5%	❌
Summary	4% (430 / 10659)	❌

AgustinBettati · 2023-12-05T09:03:33Z

internal/provider/provider_sdk2.go

+		"mongodbatlas_data_lake_pipeline_run":                                       datalakepipeline.DataSourceRun(),
+		"mongodbatlas_data_lake_pipeline_runs":                                      datalakepipeline.PluralDataSourceRun(),


should we have these in a separate package from data_lake_pipeline?

i was thinking about it but at the end I decided to have them together because there are not resources associated to them

I see, if it has some relation to the data_lake_pipeline resource then I agree it makes sense

github-actions bot added the enhancement label Dec 4, 2023

lantoli added 6 commits December 4, 2023 22:48

global_cluster_config

05cf05e

x509_authentication_database_user

34c1dd0

private_endpoint_regional_mode

3b4dea7

privatelink_endpoint_service_data_federation_online_archive

dec4ddc

privatelink_endpoint_service_serverless

779e63e

privatelink_endpoint_service

a60e6f7

lantoli force-pushed the CLOUDP-214997_file_structure_2 branch from 1b75d5e to a60e6f7 Compare December 4, 2023 21:48

lantoli added 17 commits December 4, 2023 22:57

privatelink_endpoint

e8b78d5

mongodbatlas_privatelink_endpoint_serverless and mongodbatlas_private…

bf214a7

…link_endpoint_service_serverless

third_party_integration

89e0869

online_archive

e54d4f6

custom_dns_configuration_cluster_aws

c907535

ldap_configuration and ldap_verify

800db74

search_index

903bba3

data_lake_pipeline

a9179c2

event_trigger

3516cef

project_invitation

5cce718

org_invitation

7722fd6

organization

e1ea4c8

serverless_instance

90eb6b4

cluster_outage_simulation

8f3d5f8

shared_tier

b5a3c88

roles_org_id

d924208

GH actions

c589ca9

lantoli marked this pull request as ready for review December 5, 2023 05:51

lantoli requested a review from a team as a code owner December 5, 2023 05:51

gssbzn approved these changes Dec 5, 2023

View reviewed changes

AgustinBettati reviewed Dec 5, 2023

View reviewed changes

lantoli merged commit 8c5b041 into master Dec 5, 2023

lantoli deleted the CLOUDP-214997_file_structure_2 branch December 5, 2023 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migrates some resources to new file structure #1705

feat: Migrates some resources to new file structure #1705

lantoli commented Dec 4, 2023 •

edited

Loading

github-actions bot commented Dec 5, 2023

AgustinBettati Dec 5, 2023

lantoli Dec 5, 2023

AgustinBettati Dec 5, 2023

		"mongodbatlas_data_lake_pipeline_run": datalakepipeline.DataSourceRun(),
		"mongodbatlas_data_lake_pipeline_runs": datalakepipeline.PluralDataSourceRun(),

feat: Migrates some resources to new file structure #1705

feat: Migrates some resources to new file structure #1705

Conversation

lantoli commented Dec 4, 2023 • edited Loading

Description

Type of change:

Required Checklist:

Further comments

github-actions bot commented Dec 5, 2023

AgustinBettati Dec 5, 2023

Choose a reason for hiding this comment

lantoli Dec 5, 2023

Choose a reason for hiding this comment

AgustinBettati Dec 5, 2023

Choose a reason for hiding this comment

lantoli commented Dec 4, 2023 •

edited

Loading