test: add unit test to project resource #1694

oarbusi · 2023-12-01T17:06:58Z

Description

Add unit test to project resource. Also move model methods to new model_project.go file
Link to any related issue(s):

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contribution guidelines
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

oarbusi · 2023-12-04T15:30:25Z

internal/provider/provider_authentication_test.go

@@ -24,7 +24,7 @@ func TestAccSTSAssumeRole_basic(t *testing.T) {
 		Steps: []resource.TestStep{
 			{
 				Config: acc.ConfigProject(projectName, orgID,
-					[]*matlas.ProjectTeam{},


removing references to the old SDK still in the tests of project resource

internal/service/project/data_source_project_test.go

internal/service/project/model_project.go

internal/service/project/model_project_test.go

internal/service/project/resource_project_test.go

AgustinBettati

some suggestions and feedback

internal/service/project/resource_project_test.go

AgustinBettati · 2023-12-07T11:30:17Z

internal/service/project/resource_project_test.go

+			testObject.On("RemoveProjectTeam", mock.Anything, mock.Anything, mock.Anything).Return(ProjectResponse{Err: nil})
+			testObject.On("UpdateTeamRoles", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(ProjectResponse{Err: nil})
+
+			err := project.UpdateProjectTeams(context.Background(), testObject, &testCases[i].projectState, &testCases[i].projectPlan)


nit: testing this function limits to verifying if there are errors, but not which teams have actually been updated. Looking into the implemenation getChangesInTeamsSet could be tested to see which teams are actually being removed, created, and updated.

github-actions · 2023-12-07T13:26:53Z

Package	Line Rate	Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion	31%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/dsschema	100%	✔
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate	68%	➖
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration	33%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/apikey	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/auditing	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/backupcompliancepolicy	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupschedule	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportbucket	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportjob	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotrestorejob	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudprovideraccess	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clusteroutagesimulation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdbrole	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdnsconfigurationclusteraws	5%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/datalakepipeline	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/eventtrigger	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedquerylimit	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsidentityprovider	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/globalclusterconfig	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapconfiguration	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapverify	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/maintenancewindow	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkcontainer	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/onlinearchive	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/organization	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/orginvitation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privateendpointregionalmode	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpoint	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserverless	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservice	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive	3%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserviceserverless	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project	28%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectinvitation	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist	0%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/rolesorgid	7%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment	23%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchindex	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/serverlessinstance	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streaminstance	14%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/teams	1%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/thirdpartyintegration	4%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/x509authenticationdatabaseuser	2%	❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc	5%	❌
Summary	5% (573 / 10815)	❌

oarbusi added 9 commits December 1, 2023 12:52

move model methods to model file

bb40e38

move model methods to model file

ed94913

add model file

e439814

test for transformers from skd to tf

ea97a51

lint

af34968

lint

e822de4

change matlas.ProjectTeam to admin.TeamRole

8f14eaf

fix test

0e8916e

add tests for model and methods in resource_project

c1a0e4b

oarbusi commented Dec 4, 2023

View reviewed changes

oarbusi added 4 commits December 4, 2023 18:01

test GetProjectPropsFromAPI

c292e6d

test updateProjectLimits

06fd723

test UpdateProjectTeams

93f817e

refactor

aa4a632

oarbusi marked this pull request as ready for review December 5, 2023 11:38

oarbusi requested a review from a team as a code owner December 5, 2023 11:38

lantoli reviewed Dec 5, 2023

View reviewed changes

internal/service/project/data_source_project_test.go Show resolved Hide resolved

lantoli reviewed Dec 5, 2023

View reviewed changes

internal/service/project/model_project.go Show resolved Hide resolved

lantoli reviewed Dec 5, 2023

View reviewed changes

internal/service/project/model_project_test.go Show resolved Hide resolved

lantoli approved these changes Dec 5, 2023

View reviewed changes

AgustinBettati approved these changes Dec 5, 2023

View reviewed changes

internal/service/project/resource_project_test.go Show resolved Hide resolved

internal/service/project/resource_project_test.go Outdated Show resolved Hide resolved

oarbusi added 4 commits December 7, 2023 09:34

typo

60a9a6b

lint

5a9f85e

lint

8fb4010

use testify mocks

fca90cf

AgustinBettati reviewed Dec 7, 2023

View reviewed changes

oarbusi added 3 commits December 7, 2023 14:14

change test case name

b5c95f2

remove projectId from test fixtures

a00c78c

separate mock reponses

1927451

oarbusi merged commit b915426 into master Dec 7, 2023

oarbusi deleted the CLOUDP-215182 branch December 7, 2023 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add unit test to project resource #1694

test: add unit test to project resource #1694

oarbusi commented Dec 1, 2023 •

edited

Loading

oarbusi Dec 4, 2023 •

edited

Loading

AgustinBettati left a comment

AgustinBettati Dec 7, 2023

github-actions bot commented Dec 7, 2023

test: add unit test to project resource #1694

test: add unit test to project resource #1694

Conversation

oarbusi commented Dec 1, 2023 • edited Loading

Description

Type of change:

Required Checklist:

Further comments

oarbusi Dec 4, 2023 • edited Loading

Choose a reason for hiding this comment

AgustinBettati left a comment

Choose a reason for hiding this comment

AgustinBettati Dec 7, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 7, 2023

oarbusi commented Dec 1, 2023 •

edited

Loading

oarbusi Dec 4, 2023 •

edited

Loading